Issue 189093017: Less attempted magic in pulling toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189093017: Less attempted magic in pulling toolchain (Closed)

Created:
6 years, 9 months ago by scottmg

Modified:
6 years, 9 months ago

Reviewers:
iannucci, scherkus (not reviewing)

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Less attempted magic in pulling toolchain - Don't try to wrap download_from_google_storage --config, instead just request that the user runs it manually. (This is annoying either way but making it magically run makes it less clear what's going on, and so harder to debug when something goes wrong, per linked bug). - Check that SHA1s are passed as expected on the command line in case the script is run directly, rather than from gyp_chromium. R=scherkus@chromium.org BUG=349596 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=256049