Issue 189093008: Revert of Implement '--gpu-sandbox-failures-nonfatal' flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189093008: Revert of Implement '--gpu-sandbox-failures-nonfatal' flag. (Closed)

Created:
6 years, 9 months ago by Michael van Ouwerkerk

Modified:
6 years, 9 months ago

Reviewers:
Jorge Lucangeli Obes, jln (very slow on Chromium), piman

CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, jln+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Implement '--gpu-sandbox-failures-nonfatal' flag. (https://codereview.chromium.org/189313002/) Reason for revert: Looks like this broke Linux ChromiumOS Tests (2): http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22114 Original issue's description: > Implement '--gpu-sandbox-failures-nonfatal' flag. > > Also, move the flag to content:: instead of chromeos::. > > BUG=327824 > TEST=Chrome compiles, loads with and without the flag. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255564 TBR=jln@chromium.org,piman@chromium.org,jorgelo@chromium.org NOTREECHECKS=true NOTRY=true BUG=327824 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255578

Patch Set 1 #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -30 lines)			Patch
M	chrome/browser/chromeos/login/chrome_restart_request.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chromeos/chromeos_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/chromeos_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host.cc	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	content/common/sandbox_linux/sandbox_linux.cc	View	3 chunks	+6 lines, -24 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael van Ouwerkerk

Created Revert of Implement '--gpu-sandbox-failures-nonfatal' flag.

6 years, 9 months ago (2014-03-07 11:18:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/189093008/1

6 years, 9 months ago (2014-03-07 11:19:44 UTC) #2

Message was sent while issue was closed.

Change committed as 255578

Expand Messages | Collapse Messages