Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 189093003: Merge 254840 "ppapi: Send sync point whenever the pepper texture..." (Closed)

Created:
6 years, 9 months ago by danakj
Modified:
6 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Merge 254840 "ppapi: Send sync point whenever the pepper texture..." > ppapi: Send sync point whenever the pepper texture changes. > > When giving a texture mailbox to the compositor, it's important > to give a sync point along with it, so the browser compositor does > not display the texture before it is ready. > > Currently pepper is giving the mailbox to the compositor once > (without a sync point) and then just telling it that the texture > changed, without specifying a sync point for those changes. > > Change it to always send a sync point with the mailbox, and when > the texture changes, reset the mailbox with a new sync point for > each frame. > > BUG=333024 > > Review URL: https://codereview.chromium.org/185363009 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M content/renderer/pepper/pepper_platform_context_3d.h View 2 chunks +6 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_context_3d.cc View 2 chunks +9 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +18 lines, -6 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danakj
6 years, 9 months ago (2014-03-06 22:04:07 UTC) #1
danakj
6 years, 9 months ago (2014-03-06 22:04:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255444.

Powered by Google App Engine
This is Rietveld 408576698