Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Unified Diff: cc/tiles/gpu_image_decode_controller.h

Issue 1890903002: cc: Simplify Task and its derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_tile_task_runner
Patch Set: feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/tiles/gpu_image_decode_controller.h
diff --git a/cc/tiles/gpu_image_decode_controller.h b/cc/tiles/gpu_image_decode_controller.h
index 10b03e136cccfcdbb802f4386d686f208819e8dd..32b2b4c240fca4af4e5ed385e9db278b60810b69 100644
--- a/cc/tiles/gpu_image_decode_controller.h
+++ b/cc/tiles/gpu_image_decode_controller.h
@@ -61,7 +61,7 @@ class CC_EXPORT GpuImageDecodeController : public ImageDecodeController {
// upload task to upload the image if an exsiting image does not exist.
bool GetTaskForImageAndRef(const DrawImage& image,
uint64_t prepare_tiles_id,
- scoped_refptr<ImageDecodeTask>* task) override;
+ scoped_refptr<TileTask>* task) override;
void UnrefImage(const DrawImage& image) override;
DecodedDrawImage GetDecodedImageForDraw(const DrawImage& draw_image) override;
void DrawWithImageFinished(const DrawImage& image,
@@ -135,9 +135,8 @@ class CC_EXPORT GpuImageDecodeController : public ImageDecodeController {
// Similar to GetTaskForImageAndRef, but gets the dependent decode task
// rather than the upload task, if necessary.
- scoped_refptr<ImageDecodeTask> GetImageDecodeTaskAndRef(
- const DrawImage& image,
- uint64_t prepare_tiles_id);
+ scoped_refptr<TileTask> GetImageDecodeTaskAndRef(const DrawImage& image,
+ uint64_t prepare_tiles_id);
void RefImageDecode(const DrawImage& draw_image);
void UnrefImageDecode(const DrawImage& draw_image);
@@ -170,9 +169,9 @@ class CC_EXPORT GpuImageDecodeController : public ImageDecodeController {
// All members below this point must only be accessed while holding |lock_|.
base::Lock lock_;
- std::unordered_map<uint32_t, scoped_refptr<ImageDecodeTask>>
+ std::unordered_map<uint32_t, scoped_refptr<TileTask>>
pending_image_upload_tasks_;
- std::unordered_map<uint32_t, scoped_refptr<ImageDecodeTask>>
+ std::unordered_map<uint32_t, scoped_refptr<TileTask>>
pending_image_decode_tasks_;
ImageDataMRUCache image_data_;

Powered by Google App Engine
This is Rietveld 408576698