cc/tiles/software_image_decode_controller.h - Issue 1890903002: cc: Simplify Task and its derived classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/tiles/software_image_decode_controller.h

Issue 1890903002: cc: Simplify Task and its derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_tile_task_runner

Patch Set: feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/tiles/software_image_decode_controller.h

diff --git a/cc/tiles/software_image_decode_controller.h b/cc/tiles/software_image_decode_controller.h

index 9697720fb3dcec73d1accc7db5ef0ab02eb29fe3..8f6ed0d60e0a7fcd641803dca5ed51710317a131 100644

--- a/cc/tiles/software_image_decode_controller.h

+++ b/cc/tiles/software_image_decode_controller.h

@@ -110,7 +110,7 @@ class CC_EXPORT SoftwareImageDecodeController

// ImageDecodeController overrides.

bool GetTaskForImageAndRef(const DrawImage& image,

uint64_t prepare_tiles_id,

- scoped_refptr<ImageDecodeTask>* task) override;

+ scoped_refptr<TileTask>* task) override;

void UnrefImage(const DrawImage& image) override;

DecodedDrawImage GetDecodedImageForDraw(const DrawImage& image) override;

void DrawWithImageFinished(const DrawImage& image,

@@ -241,7 +241,7 @@ class CC_EXPORT SoftwareImageDecodeController

const char* cache_name,

base::trace_event::ProcessMemoryDump* pmd) const;

- std::unordered_map<ImageKey, scoped_refptr<ImageDecodeTask>, ImageKeyHash>

+ std::unordered_map<ImageKey, scoped_refptr<TileTask>, ImageKeyHash>

pending_image_tasks_;

// The members below this comment can only be accessed if the lock is held to

« cc/raster/tile_task_runner.h ('K') | « cc/tiles/image_decode_controller.h ('k') | cc/tiles/software_image_decode_controller.cc » ('j') | no next file with comments »