Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: cc/raster/tile_task_runner.cc

Issue 1890903002: cc: Simplify Task and its derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_tile_task_runner
Patch Set: feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/raster/tile_task_runner.h" 5 #include "cc/raster/tile_task_runner.h"
6 #include "cc/resources/platform_color.h" 6 #include "cc/resources/platform_color.h"
7 7
8 namespace cc { 8 namespace cc {
9 9
10 TileTask::TileTask() : did_schedule_(false), did_complete_(false) { 10 TileTask::TileTask(bool supports_concurrent_execution)
11 } 11 : supports_concurrent_execution_(supports_concurrent_execution),
12 did_schedule_(false),
13 did_complete_(false) {}
14
15 TileTask::TileTask(bool supports_concurrent_execution,
16 TileTask::Vector* dependencies)
17 : supports_concurrent_execution_(supports_concurrent_execution),
18 dependencies_(std::move(*dependencies)),
19 did_schedule_(false),
20 did_complete_(false) {}
12 21
13 TileTask::~TileTask() { 22 TileTask::~TileTask() {
14 DCHECK(!did_schedule_); 23 DCHECK(!did_schedule_);
15 DCHECK(!did_run_ || did_complete_); 24 DCHECK(!did_run_ || did_complete_);
16 } 25 }
17 26
18 void TileTask::WillSchedule() { 27 void TileTask::WillSchedule() {
19 DCHECK(!did_schedule_); 28 DCHECK(!did_schedule_);
20 } 29 }
21 30
(...skipping 14 matching lines...) Expand all
36 DCHECK(did_schedule_); 45 DCHECK(did_schedule_);
37 DCHECK(!did_complete_); 46 DCHECK(!did_complete_);
38 did_schedule_ = false; 47 did_schedule_ = false;
39 did_complete_ = true; 48 did_complete_ = true;
40 } 49 }
41 50
42 bool TileTask::HasCompleted() const { 51 bool TileTask::HasCompleted() const {
43 return did_complete_; 52 return did_complete_;
44 } 53 }
45 54
46 ImageDecodeTask::ImageDecodeTask() {
47 }
48
49 ImageDecodeTask::ImageDecodeTask(scoped_refptr<ImageDecodeTask> dependency)
50 : dependency_(std::move(dependency)) {}
51
52 ImageDecodeTask::~ImageDecodeTask() {
53 }
54
55 bool ImageDecodeTask::SupportsConcurrentExecution() const {
56 return true;
57 }
58
59 RasterTask::RasterTask(ImageDecodeTask::Vector* dependencies) {
60 dependencies_.swap(*dependencies);
61 }
62
63 RasterTask::~RasterTask() {
64 }
65
66 bool TileTaskRunner::ResourceFormatRequiresSwizzle(ResourceFormat format) { 55 bool TileTaskRunner::ResourceFormatRequiresSwizzle(ResourceFormat format) {
67 switch (format) { 56 switch (format) {
68 case RGBA_8888: 57 case RGBA_8888:
69 case BGRA_8888: 58 case BGRA_8888:
70 // Initialize resource using the preferred PlatformColor component 59 // Initialize resource using the preferred PlatformColor component
71 // order and swizzle in the shader instead of in software. 60 // order and swizzle in the shader instead of in software.
72 return !PlatformColor::SameComponentOrder(format); 61 return !PlatformColor::SameComponentOrder(format);
73 case RGBA_4444: 62 case RGBA_4444:
74 case ETC1: 63 case ETC1:
75 case ALPHA_8: 64 case ALPHA_8:
76 case LUMINANCE_8: 65 case LUMINANCE_8:
77 case RGB_565: 66 case RGB_565:
78 case RED_8: 67 case RED_8:
79 case LUMINANCE_F16: 68 case LUMINANCE_F16:
80 return false; 69 return false;
81 } 70 }
82 NOTREACHED(); 71 NOTREACHED();
83 return false; 72 return false;
84 } 73 }
85 74
86 } // namespace cc 75 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698