Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1890873002: Revert of [build] Use MSVS 2015 by default. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [build] Use MSVS 2015 by default. (patchset #4 id:60001 of https://codereview.chromium.org/1886983002/ ) Reason for revert: Introduced flaky crashes on win debug. Original issue's description: > [build] Use MSVS 2015 by default. > > BUG=chromium:603131 > LOG=y > > Committed: https://crrev.com/e51e8b4ad77008ec7f88c144853e01001dbea900 > Cr-Commit-Position: refs/heads/master@{#35487} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:603131 Committed: https://crrev.com/290ee88f63a3b94d87483dbd71ab9f581349ddc6 Cr-Commit-Position: refs/heads/master@{#35498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -113 lines) Patch
M build/config/win/msvs_dependencies.isolate View 4 chunks +1 line, -104 lines 0 comments Download
M build/get_landmines.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/isolate.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/standalone.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M build/vs_toolchain.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [build] Use MSVS 2015 by default.
4 years, 8 months ago (2016-04-14 14:52:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890873002/1
4 years, 8 months ago (2016-04-14 14:53:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 14:53:14 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 14:54:11 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/290ee88f63a3b94d87483dbd71ab9f581349ddc6
Cr-Commit-Position: refs/heads/master@{#35498}

Powered by Google App Engine
This is Rietveld 408576698