Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1890863003: Change the bookmark ripple/hover to be 24px in height. (Closed)

Created:
4 years, 8 months ago by bruthig
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, bruthig+ink_drop_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the bookmark ripple/hover to be 24px in height. BUG=595317 TEST=manual Committed: https://crrev.com/3f6febc32fb72163c187ce1e4f88420ec111725c Cr-Commit-Position: refs/heads/master@{#387461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 3 chunks +16 lines, -6 lines 0 comments Download
M ui/views/animation/flood_fill_ink_drop_animation.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
bruthig
sky@, can you PTAL?
4 years, 8 months ago (2016-04-14 20:38:52 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-14 21:09:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890863003/1
4 years, 8 months ago (2016-04-14 21:34:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 22:40:02 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 22:41:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f6febc32fb72163c187ce1e4f88420ec111725c
Cr-Commit-Position: refs/heads/master@{#387461}

Powered by Google App Engine
This is Rietveld 408576698