src/compiler/simplified-lowering.cc - Issue 1890803002: [wasm] Generate source position information

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 1890803002: [wasm] Generate source position information (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-throw-error

Patch Set: some doc and fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index 176a9ea7408887607e17e92fd81cad4512894759..040dc2cd9589f5702cf2a32a96b25363ddcf8d35 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -305,8 +305,8 @@ class RepresentationSelector {

NodeInfo* info = GetInfo(node);

TRACE(" visit #%d: %s\n", node->id(), node->op()->mnemonic());

// Reuse {VisitNode()} so the representation rules are in one place.

- SourcePositionTable::Scope scope(

- source_positions_, source_positions_->GetSourcePosition(node));

+ SourcePositionScope scope(source_positions_,

+ source_positions_->GetSourcePosition(node));

VisitNode(node, info->truncation(), lowering);

}