Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1890783002: Use singular when only one item is selected. (Closed)

Created:
4 years, 8 months ago by oka
Modified:
4 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use singular when only one item is selected. BUG=592372 TEST=manually Committed: https://crrev.com/f670eeb7656e38a0953bd971c612c7fe407fe039 Cr-Commit-Position: refs/heads/master@{#387266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/toolbar_controller.js View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
oka
PTAL
4 years, 8 months ago (2016-04-14 08:07:44 UTC) #2
fukino
lgtm
4 years, 8 months ago (2016-04-14 08:19:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890783002/1
4 years, 8 months ago (2016-04-14 08:20:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 08:56:48 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 08:58:15 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f670eeb7656e38a0953bd971c612c7fe407fe039
Cr-Commit-Position: refs/heads/master@{#387266}

Powered by Google App Engine
This is Rietveld 408576698