|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by François Beaufort Modified:
4 years, 8 months ago CC:
chromium-reviews, Ilya Sherman Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll cros_system_api DEPS for BlueZ D-Bus ServicesResolved property
BUG=599472
Committed: https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db
Cr-Commit-Position: refs/heads/master@{#388163}
Patch Set 1 #Patch Set 2 : git rebase-update #Messages
Total messages: 20 (11 generated)
Description was changed from ========== Roll cros_system_api DEPS for BlueZ D-Bus ServicesResolved property BUG=599472 ========== to ========== Roll cros_system_api DEPS for BlueZ D-Bus ServicesResolved property BUG=599472 ==========
beaufort.francois@gmail.com changed reviewers: + isherman@chromium.org
Hello Ilya, Could you have a quick look at this CL? Thank you in advance, Francois
isherman@chromium.org changed reviewers: + scheib@chromium.org, tengs@chromium.org
Sorry, I don't think I'm an appropriate reviewer for this CL. Perhaps Tim or Vincent can help.
scheib@chromium.org changed reviewers: + mcchou@chromium.org
I'm unfamiliar with this, mcchou, do you have context for this?
mcchou@chromium.org changed reviewers: - isherman@chromium.org
After going through the discussion(https://groups.google.com/a/chromium.org/forum/#!msg/web-bluetooth/PQpZAFNlvT4/8enjsHNjIQAJ), I think this CL is for picking up the changes on service_constants.h. lgtm
The CQ bit was checked by beaufort.francois@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890763005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by beaufort.francois@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from mcchou@chromium.org Link to the patchset: https://codereview.chromium.org/1890763005/#ps20001 (title: "git rebase-update")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890763005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890763005/20001
Message was sent while issue was closed.
Description was changed from ========== Roll cros_system_api DEPS for BlueZ D-Bus ServicesResolved property BUG=599472 ========== to ========== Roll cros_system_api DEPS for BlueZ D-Bus ServicesResolved property BUG=599472 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Roll cros_system_api DEPS for BlueZ D-Bus ServicesResolved property BUG=599472 ========== to ========== Roll cros_system_api DEPS for BlueZ D-Bus ServicesResolved property BUG=599472 Committed: https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db Cr-Commit-Position: refs/heads/master@{#388163} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db Cr-Commit-Position: refs/heads/master@{#388163} |
