Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1890763002: [turbofan] Remove unused PlainPrimitiveToNumber operator. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove unused PlainPrimitiveToNumber operator. At some point we thought about using this instead of JSToNumber, but now there doesn't seem to be any reason for this anymore. R=jarin@chromium.org Committed: https://crrev.com/5b99eec34289cbc2c363a534fed278d8790e4693 Cr-Commit-Position: refs/heads/master@{#35469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-14 07:13:22 UTC) #1
Jarin
lgtm
4 years, 8 months ago (2016-04-14 07:14:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890763002/1
4 years, 8 months ago (2016-04-14 07:15:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 07:41:08 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 07:42:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b99eec34289cbc2c363a534fed278d8790e4693
Cr-Commit-Position: refs/heads/master@{#35469}

Powered by Google App Engine
This is Rietveld 408576698