third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 1890733002: Make code generator understand FrozenArray

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 1890733002: Make code generator understand FrozenArray (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index dc18cf246643ba8fa23fbe66bbbaaa04d0cd94c8..f8821fcb82cde7ce076400aa98ddfab284cc9248 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -864,6 +864,7 @@ CPP_VALUE_TO_V8_VALUE = {

'ScriptValue': '{cpp_value}.v8Value()',

'SerializedScriptValue': '{cpp_value} ? {cpp_value}->deserialize() : v8::Local<v8::Value>(v8::Null({isolate}))',

# General

+ # TODO(bashi): Freeze converted array when the type is FrozenArray.

'array': 'toV8({cpp_value}, {creation_context}, {isolate})',

'DOMWrapper': 'toV8({cpp_value}, {creation_context}, {isolate})',

# Passing nullable dictionaries isn't a pattern currently used