Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1890703002: Revert of Reland Combined test runner. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Reland Combined test runner. (patchset #4 id:60001 of https://codereview.chromium.org/1886753002/ ) Reason for revert: Dr. Memory still broken: https://build.chromium.org/p/client.pdfium/builders/drm_win_xfa/builds/330/steps/pixel%20tests/logs/stdio Original issue's description: > Reland Combined test runner. > > This reverts commit 7a4374583efc0c41c826122aa26c1198c8d5cc37. > > Original Commit Message: > > This CL revives the old CL to combine the test runners [1] which was reverted > due to failing font_size tests. I've deleted the font_size.pdf as it is not > needed and for testing. Pixel tests are either .in or .pdf files, not both. > > Original description: > This CL takes the three test runners (corpus, javascript, pixel) and combines > the code into a single test_runner file. Each of the individual runners still > exists and calls the test runner with their data directory. > > With this change, the pixel and javascript test will now run in parallel if > multiple processors are available. > > 1-https://codereview.chromium.org/1430623006/ > > Committed: https://pdfium.googlesource.com/pdfium/+/9cec54ab0a5461b3075c585f8f233dbfd06c2cbd TBR=tsepez@chromium.org,ochang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/6e0d67d4f55fc7cb4632f4c5d08cd7565a237d30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+424 lines, -244 lines) Patch
A testing/resources/pixel/font_size.pdf View 1 chunk +72 lines, -0 lines 0 comments Download
M testing/tools/run_corpus_tests.py View 1 chunk +164 lines, -3 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 1 chunk +90 lines, -3 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 chunk +98 lines, -3 lines 0 comments Download
D testing/tools/test_runner.py View 1 chunk +0 lines, -235 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dsinclair
Created Revert of Reland Combined test runner.
4 years, 8 months ago (2016-04-14 02:13:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890703002/1
4 years, 8 months ago (2016-04-14 02:13:15 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 02:13:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6e0d67d4f55fc7cb4632f4c5d08cd7565a23...

Powered by Google App Engine
This is Rietveld 408576698