Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1890643002: Mojo: add native type mapping for base::FilePath (Closed)

Created:
4 years, 8 months ago by yzshen1
Modified:
4 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@25_typemap
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: add native type mapping for base::FilePath BUG=598821 Committed: https://crrev.com/cac9288c20778ff7507779a65533fc12d9a57d8c Cr-Commit-Position: refs/heads/master@{#388225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -5 lines) Patch
M mojo/common/BUILD.gn View 3 chunks +22 lines, -0 lines 0 comments Download
A + mojo/common/common_custom_types.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A mojo/common/common_custom_types.typemap View 1 chunk +12 lines, -0 lines 0 comments Download
A mojo/common/common_custom_types_unittest.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A mojo/common/test_common_custom_types.mojom View 1 chunk +12 lines, -0 lines 0 comments Download
A + mojo/common/typemaps.gni View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/mojo_base.gyp View 4 chunks +37 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yzshen1
Hi, Ben. Would you please take a look? Thanks! This CL depends on https://codereview.chromium.org/1832703002/
4 years, 8 months ago (2016-04-13 20:42:09 UTC) #2
Ben Goodger (Google)
could this live in //base/mojo ?
4 years, 8 months ago (2016-04-13 20:45:57 UTC) #3
yzshen1
On 2016/04/13 20:45:57, Ben Goodger (Google) wrote: > could this live in //base/mojo ? I ...
4 years, 8 months ago (2016-04-13 20:52:16 UTC) #4
Ben Goodger (Google)
On 2016/04/13 20:52:16, yzshen1 wrote: > On 2016/04/13 20:45:57, Ben Goodger (Google) wrote: > > ...
4 years, 8 months ago (2016-04-13 20:57:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890643002/1
4 years, 8 months ago (2016-04-19 15:44:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 16:54:21 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:12:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cac9288c20778ff7507779a65533fc12d9a57d8c
Cr-Commit-Position: refs/heads/master@{#388225}

Powered by Google App Engine
This is Rietveld 408576698