Add nasko+codewatch@chromium.org.

Add nasko+codewatch@chromium.org.

R=creis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255614

[nasko, 2014-03-06 22:41:47]

Hey Charlie,
Can you review this CL for me? I want to add myself to be notified of CLs in the
directories we do most of the navigation work.
Thanks in advance!

[Charlie Reis, 2014-03-06 22:52:00]

https://codereview.chromium.org/189063003/diff/1/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/189063003/diff/1/WATCHLISTS#newcode410
WATCHLISTS:410: 'content/browser/renderer_host/render.*host.*|'\
This will include all of the platform-specific render_widget_host_view_mumble
classes.  Is that intentional?  Navigation shouldn't really affect those, so I
might recommend limiting it to render_view_host.*.

https://codereview.chromium.org/189063003/diff/1/WATCHLISTS#newcode412
WATCHLISTS:412: 'content/renderer'
content/renderer is pretty huge, and most isn't navigation related.  Maybe we
should narrow it down?

https://codereview.chromium.org/189063003/diff/1/WATCHLISTS#newcode806
WATCHLISTS:806: 'navigation': ['nasko+codewatch@chromium.org'],
Can you put creis+watch@chromium.org as well?  :)

[nasko, 2014-03-06 23:01:39]

https://codereview.chromium.org/189063003/diff/1/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/189063003/diff/1/WATCHLISTS#newcode410
WATCHLISTS:410: 'content/browser/renderer_host/render.*host.*|'\
On 2014/03/06 22:52:01, Charlie Reis wrote:
> This will include all of the platform-specific render_widget_host_view_mumble
> classes.  Is that intentional?  Navigation shouldn't really affect those, so I
> might recommend limiting it to render_view_host.*.

Wanted to include RenderProcessHost, but you are right that this is more than
needed. Added it separately.

https://codereview.chromium.org/189063003/diff/1/WATCHLISTS#newcode412
WATCHLISTS:412: 'content/renderer'
On 2014/03/06 22:52:01, Charlie Reis wrote:
> content/renderer is pretty huge, and most isn't navigation related.  Maybe we
> should narrow it down?

Done.

https://codereview.chromium.org/189063003/diff/1/WATCHLISTS#newcode806
WATCHLISTS:806: 'navigation': ['nasko+codewatch@chromium.org'],
On 2014/03/06 22:52:01, Charlie Reis wrote:
> Can you put mailto:creis+watch@chromium.org as well?  :)

I wasn't sure if you are interested ;). Added.

[Charlie Reis, 2014-03-07 01:40:45]

LGTM

[nasko, 2014-03-07 06:22:39]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2014-03-07 06:23:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nasko@chromium.org/189063003/40001

[commit-bot: I haz the power, 2014-03-07 06:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 06:58:03]

Try jobs failed on following builders: mac_chromium_compile_dbg,
mac_chromium_rel

[nasko, 2014-03-07 14:56:46]

Committed patchset #3 manually as r255614 (presubmit successful).