Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1890603003: Add Mojo{Set,Get}DataPipeProducerOptions() to the standard/native system thunks. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add Mojo{Set,Get}DataPipeProducerOptions() to the standard/native system thunks. This is just like 57418b2bb4965547dc7a4f99c4d0e2ce05cd0c7f, but for producers (and write thresholds). * I actually added the system thunks properly in this change (remembered to update system_thunks.c). * Like the aforementioned change, no NaCl thunks. * Otherwise, the only "interesting" part of the change is CoreTest.DataPipeThreshold. R=vardhan@google.com BUG=#442 Committed: https://chromium.googlesource.com/external/mojo/+/2e863a08c4bd5fd81086d5cb6de64a53ee01a68f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -1 line) Patch
M mojo/edk/embedder/entrypoints.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 1 chunk +134 lines, -1 line 0 comments Download
M mojo/public/platform/native/system_thunks.h View 2 chunks +9 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_thunks.c View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 8 months ago (2016-04-13 20:27:43 UTC) #1
vardhan
lgtm
4 years, 8 months ago (2016-04-13 21:53:46 UTC) #2
viettrungluu
4 years, 8 months ago (2016-04-13 22:35:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e863a08c4bd5fd81086d5cb6de64a53ee01a68f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698