Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1890603002: Partly revert https://codereview.chromium.org/1860273003/ where paint follows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index e8861f95dae46c53e73d9a10c6d6ef7bf67293f6..b886fb36d27421507a08522093845644a9c9b674 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -303,7 +303,8 @@ public:
if (!frame()->document() || !frame()->document()->layoutView())
return 0;
- frame()->view()->updateLifecycleToCompositingCleanPlusScrolling();
+ // TODO(crbug.com/603230): Synchronized painting is unnecessary in this lifecycle update.
+ frame()->view()->updateAllLifecyclePhases();
if (!frame()->document() || !frame()->document()->layoutView())
return 0;
@@ -322,8 +323,7 @@ public:
if (!frame()->document() || !frame()->document()->layoutView())
return;
- // TODO(chrishtr): this should be updateLifecycleToCompositingCleanPlusScrolling, but
- // for some reason it makes printing/absolute-position-headers-and-footers.html fail.
+ // TODO(crbug.com/603230): Synchronized painting is unnecessary in this lifecycle update.
frame()->view()->updateAllLifecyclePhases();
if (!frame()->document() || !frame()->document()->layoutView())
return;
« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698