Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 1890603002: Partly revert https://codereview.chromium.org/1860273003/ where paint follows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index 80e692a96d2c29a743fcd76d8e388a8890f506ce..9350b3b94080cd318db48593e4121284581cc54b 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -619,7 +619,8 @@ double LocalFrame::devicePixelRatio() const
PassOwnPtr<DragImage> LocalFrame::nodeImage(Node& node)
{
- m_view->updateLifecycleToCompositingCleanPlusScrolling();
+ // TODO(crbug.com/603230): Synchronized painting is unnecessary in this lifecycle update.
+ m_view->updateAllLifecyclePhases();
LayoutObject* layoutObject = node.layoutObject();
if (!layoutObject)
return nullptr;
@@ -645,7 +646,8 @@ PassOwnPtr<DragImage> LocalFrame::dragImageForSelection(float opacity)
if (!selection().isRange())
return nullptr;
- m_view->updateLifecycleToCompositingCleanPlusScrolling();
+ // TODO(crbug.com/603230): Synchronized painting is unnecessary in the lifecycle update.
+ m_view->updateAllLifecyclePhases();
ASSERT(document()->isActive());
FloatRect paintingRect = FloatRect(selection().bounds());
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698