third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp - Issue 1890603002: Partly revert https://codereview.chromium.org/1860273003/ where paint follows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

Issue 1890603002: Partly revert https://codereview.chromium.org/1860273003/ where paint follows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/LocalFrame.cpp ('K') | « third_party/WebKit/Source/core/frame/LocalFrame.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

index bf916658585ccc7a05988b08e658f67208bfb4e9..4e716871bb1eb2d1cd759e13d735435af57b7759 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

@@ -358,7 +358,8 @@ void SVGImage::drawInternal(SkCanvas* canvas, const SkPaint& paint, const FloatR

transform.scale(scale.width(), scale.height());

TransformRecorder transformRecorder(imagePicture.context(), *this, transform);

- view->updateLifecycleToCompositingCleanPlusScrolling();

+ // TODO(wangxianzhu): Don't need synchronized painting.

+ view->updateAllLifecyclePhases();

view->paint(imagePicture.context(), CullRect(enclosingIntRect(srcRect)));

ASSERT(!view->needsLayout());

}