Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1890583002: Renaming App List Shower to App List Presenter (Closed)

Created:
4 years, 8 months ago by mfomitchev
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, sky
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, tapted, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming App List Shower to App List Presenter BUG=NONE Committed: https://crrev.com/da899d880ca2debd2bcef5e7d6d1d5435048ed05 Cr-Commit-Position: refs/heads/master@{#387722}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix #

Patch Set 4 : Fix #

Patch Set 5 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+610 lines, -2247 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
A + ash/app_list/app_list_presenter_delegate.h View 6 chunks +14 lines, -14 lines 0 comments Download
A + ash/app_list/app_list_presenter_delegate.cc View 13 chunks +43 lines, -45 lines 0 comments Download
A ash/app_list/app_list_presenter_delegate_factory.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ash/app_list/app_list_presenter_delegate_factory.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A + ash/app_list/app_list_presenter_delegate_unittest.cc View 9 chunks +26 lines, -23 lines 0 comments Download
D ash/app_list/app_list_shower_delegate.h View 1 chunk +0 lines, -102 lines 0 comments Download
D ash/app_list/app_list_shower_delegate.cc View 1 chunk +0 lines, -357 lines 0 comments Download
D ash/app_list/app_list_shower_delegate_factory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ash/app_list/app_list_shower_delegate_factory.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D ash/app_list/app_list_shower_delegate_unittest.cc View 1 chunk +0 lines, -196 lines 0 comments Download
M ash/app_list/app_list_view_delegate_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/ash.gyp View 6 chunks +9 lines, -9 lines 0 comments Download
M ash/mus/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/shell_delegate_mus.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/shell_delegate_mus.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M ash/shell.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download
M ash/shell_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/test/shell_test_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/shell_test_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/test_shell_delegate.h View 4 chunks +8 lines, -8 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M build/all.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/custom_launcher_page_browsertest_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.cc View 7 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/app_list/test/app_list_service_ash_test_api.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/app_list/test/app_list_service_ash_test_api.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +3 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 7 chunks +7 lines, -7 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 10 chunks +10 lines, -10 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +5 lines, -5 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 chunk +1 line, -1 line 0 comments Download
A + ui/app_list/presenter/BUILD.gn View 2 chunks +14 lines, -14 lines 0 comments Download
A + ui/app_list/presenter/app_list_presenter.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/app_list/presenter/app_list_presenter.gyp View 4 chunks +22 lines, -22 lines 0 comments Download
A + ui/app_list/presenter/app_list_presenter_delegate.h View 3 chunks +9 lines, -8 lines 0 comments Download
A ui/app_list/presenter/app_list_presenter_delegate_factory.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ui/app_list/presenter/app_list_presenter_export.h View 1 chunk +32 lines, -0 lines 0 comments Download
A + ui/app_list/presenter/app_list_presenter_impl.h View 5 chunks +17 lines, -17 lines 0 comments Download
A + ui/app_list/presenter/app_list_presenter_impl.cc View 12 chunks +41 lines, -40 lines 0 comments Download
A + ui/app_list/presenter/app_list_presenter_impl_unittest.cc View 1 8 chunks +58 lines, -55 lines 0 comments Download
A + ui/app_list/presenter/app_list_presenter_unittests.isolate View 3 chunks +3 lines, -3 lines 0 comments Download
A + ui/app_list/presenter/test/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/app_list/presenter/test/app_list_presenter_impl_test_api.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ui/app_list/presenter/test/app_list_presenter_impl_test_api.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A + ui/app_list/presenter/test/run_all_unittests.cc View 2 chunks +8 lines, -7 lines 0 comments Download
D ui/app_list/shower/BUILD.gn View 1 chunk +0 lines, -71 lines 0 comments Download
D ui/app_list/shower/app_list_shower.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/app_list/shower/app_list_shower.gyp View 1 chunk +0 lines, -107 lines 0 comments Download
D ui/app_list/shower/app_list_shower_delegate.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/app_list/shower/app_list_shower_delegate_factory.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/app_list/shower/app_list_shower_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/app_list/shower/app_list_shower_impl.h View 1 chunk +0 lines, -120 lines 0 comments Download
D ui/app_list/shower/app_list_shower_impl.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D ui/app_list/shower/app_list_shower_impl_unittest.cc View 1 1 chunk +0 lines, -206 lines 0 comments Download
D ui/app_list/shower/app_list_shower_unittests.isolate View 1 chunk +0 lines, -78 lines 0 comments Download
D ui/app_list/shower/test/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/app_list/shower/test/app_list_shower_impl_test_api.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/app_list/shower/test/app_list_shower_impl_test_api.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/app_list/shower/test/run_all_unittests.cc View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mfomitchev
4 years, 8 months ago (2016-04-13 21:18:09 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-13 23:50:40 UTC) #3
mfomitchev
brettw@chromium.org: Please review changes in BUILD.gn build/*
4 years, 8 months ago (2016-04-14 00:17:51 UTC) #4
mfomitchev
dpranke@chromium.org: Please review changes in BUILD.gn build/*
4 years, 8 months ago (2016-04-15 15:59:28 UTC) #6
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-15 21:17:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890583002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890583002/80001
4 years, 8 months ago (2016-04-15 21:21:10 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-15 22:21:49 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 22:23:40 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/da899d880ca2debd2bcef5e7d6d1d5435048ed05
Cr-Commit-Position: refs/heads/master@{#387722}

Powered by Google App Engine
This is Rietveld 408576698