Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1890573003:
For GOOGLE3, add deref method to SkRefCnt. (Closed)
DescriptionFor GOOGLE3, add deref method to SkRefCnt.
This makes it easier to integrate with Blink code using RefPtr/PassRefPtr without pulling in Chrome's SkUserConfig.h.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1890573003
Committed: https://skia.googlesource.com/skia/+/f9634b95eccd58acf5b20d98c5d2ee5af353d3d2
Patch Set 1 : #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== Add deref method to SkRefCnt, guarded by SK_REF_CNT_HAS_DEREF. This makes it easier to integrate with Blink code using RefPtr/PassRefPtr without pulling in Chrome's SkUserConfig.h. BUG=skia: ========== to ========== Add deref method to SkRefCnt, guarded by SK_REF_CNT_HAS_DEREF. This makes it easier to integrate with Blink code using RefPtr/PassRefPtr without pulling in Chrome's SkUserConfig.h. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add deref method to SkRefCnt, guarded by SK_REF_CNT_HAS_DEREF. This makes it easier to integrate with Blink code using RefPtr/PassRefPtr without pulling in Chrome's SkUserConfig.h. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== For GOOGLE3, add deref method to SkRefCnt. This makes it easier to integrate with Blink code using RefPtr/PassRefPtr without pulling in Chrome's SkUserConfig.h. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Patchset #1 (id:1) has been deleted
Patchset #3 (id:60001) has been deleted
Patchset #2 (id:40001) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890573003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890573003/80001
benjaminwagner@google.com changed reviewers: + mtklein@google.com
mtklein@google.com changed reviewers: + reed@google.com
+reed for public API / FYI lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I don't want to know :) lgtm
The CQ bit was checked by benjaminwagner@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890573003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890573003/80001
Message was sent while issue was closed.
Description was changed from ========== For GOOGLE3, add deref method to SkRefCnt. This makes it easier to integrate with Blink code using RefPtr/PassRefPtr without pulling in Chrome's SkUserConfig.h. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== For GOOGLE3, add deref method to SkRefCnt. This makes it easier to integrate with Blink code using RefPtr/PassRefPtr without pulling in Chrome's SkUserConfig.h. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/f9634b95eccd58acf5b20d98c5d2ee5af353d3d2 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:80001) as https://skia.googlesource.com/skia/+/f9634b95eccd58acf5b20d98c5d2ee5af353d3d2 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
