Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1890573003: For GOOGLE3, add deref method to SkRefCnt. (Closed)

Created:
4 years, 8 months ago by dogben
Modified:
4 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

For GOOGLE3, add deref method to SkRefCnt. This makes it easier to integrate with Blink code using RefPtr/PassRefPtr without pulling in Chrome's SkUserConfig.h. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1890573003 Committed: https://skia.googlesource.com/skia/+/f9634b95eccd58acf5b20d98c5d2ee5af353d3d2

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M include/core/SkRefCnt.h View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890573003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890573003/80001
4 years, 8 months ago (2016-04-13 22:08:25 UTC) #8
dogben
4 years, 8 months ago (2016-04-13 22:13:12 UTC) #10
mtklein
+reed for public API / FYI lgtm
4 years, 8 months ago (2016-04-13 22:15:53 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 22:27:36 UTC) #14
reed1
I don't want to know :) lgtm
4 years, 8 months ago (2016-04-13 22:40:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890573003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890573003/80001
4 years, 8 months ago (2016-04-14 00:51:02 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 00:52:01 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:80001) as
https://skia.googlesource.com/skia/+/f9634b95eccd58acf5b20d98c5d2ee5af353d3d2

Powered by Google App Engine
This is Rietveld 408576698