xfa/fxfa/app/xfa_ffdocview.cpp - Issue 1890563003: Simplify XFA event handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffdocview.cpp

Issue 1890563003: Simplify XFA event handling. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Events / params ignored by CPDFXFA_Document::WidgetEvent(). Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_ffdocview.cpp

diff --git a/xfa/fxfa/app/xfa_ffdocview.cpp b/xfa/fxfa/app/xfa_ffdocview.cpp

index daa5fd6277c49dc6c80ac213f87e2a300d57206c..2a5a985eb44e6bf84748020babe61c12d9cf2139 100644

--- a/xfa/fxfa/app/xfa_ffdocview.cpp

+++ b/xfa/fxfa/app/xfa_ffdocview.cpp

@@ -215,13 +215,8 @@ FX_BOOL CXFA_FFDocView::ResetSingleWidgetAccData(CXFA_WidgetAcc* pWidgetAcc) {

if (eType != XFA_ELEMENT_Field && eType != XFA_ELEMENT_ExclGroup) {

return FALSE;

}

- FX_BOOL bNotify = IsStaticNotify();

Tom Sepez 2016/04/14 22:08:55 How do we know its not doctype static?

Lei Zhang 2016/04/14 22:11:50 We don't care because nobody listens for XFA_WIDGE

Tom Sepez 2016/04/14 22:45:43 Acknowledged.

pWidgetAcc->ResetData();

pWidgetAcc->UpdateUIDisplay();

- if (bNotify) {

- pWidgetAcc->NotifyEvent(XFA_WIDGETEVENT_PostContentChanged, NULL, NULL,

- NULL);

- }

if (CXFA_Validate validate = pWidgetAcc->GetValidate()) {

AddValidateWidget(pWidgetAcc);

validate.GetNode()->SetFlag(XFA_NODEFLAG_NeedsInitApp, TRUE, FALSE);