Simplify XFA event handling.

xfa/fxfa/parser/xfa_object.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FXFA_PARSER_XFA_OBJECT_H_
 #define XFA_FXFA_PARSER_XFA_OBJECT_H_
 
 #include "xfa/fde/xml/fde_xml.h"
@@ skipping 30 matching lines @@
 };
 class CXFA_Object {
  public:
   CXFA_Object(CXFA_Document* pDocument, uint32_t uFlags);
   CXFA_Document* GetDocument() const { return m_pDocument; }
   uint32_t GetFlag() const { return m_uFlags; }
   XFA_OBJECTTYPE GetObjectType() const {
     return (XFA_OBJECTTYPE)(m_uFlags & XFA_OBJECTTYPEMASK);
   }
 
-  FX_BOOL IsNode() const {
+  bool IsNode() const {
     return (m_uFlags & XFA_OBJECTTYPEMASK) >= XFA_OBJECTTYPE_Node;
   }
-  FX_BOOL IsOrdinaryObject() const {
+  bool IsOrdinaryObject() const {
     return (m_uFlags & XFA_OBJECTTYPEMASK) == XFA_OBJECTTYPE_OrdinaryObject;
   }
-  FX_BOOL IsNodeList() const {
+  bool IsNodeList() const {
     return (m_uFlags & XFA_OBJECTTYPEMASK) == XFA_OBJECTTYPE_NodeList;
   }
-  FX_BOOL IsOrdinaryList() const {
+  bool IsOrdinaryList() const {
     return (m_uFlags & XFA_OBJECTTYPEMASK) == XFA_OBJECTTYPE_OrdinaryList;
   }
-  FX_BOOL IsContentNode() const {
+  bool IsContentNode() const {
     return (m_uFlags & XFA_OBJECTTYPEMASK) == XFA_OBJECTTYPE_ContentNode;
   }
-  FX_BOOL IsContainerNode() const {
+  bool IsContainerNode() const {
     return (m_uFlags & XFA_OBJECTTYPEMASK) == XFA_OBJECTTYPE_ContainerNode;
   }
 
   CXFA_Node* AsNode();
   CXFA_OrdinaryObject* AsOrdinaryObject();
   CXFA_NodeList* AsNodeList();
 
   const CXFA_Node* AsNode() const;
   const CXFA_OrdinaryObject* AsOrdinaryObject() const;
   const CXFA_NodeList* AsNodeList() const;
@@ skipping 50 matching lines @@
 };
 
 #define XFA_CalcRefCount (void*)(uintptr_t) FXBSTR_ID('X', 'F', 'A', 'R')
 #define XFA_CalcData (void*)(uintptr_t) FXBSTR_ID('X', 'F', 'A', 'C')
 #define XFA_LAYOUTITEMKEY (void*)(uintptr_t) FXBSTR_ID('L', 'Y', 'I', 'M')
 class CXFA_Node : public CXFA_Object {
  public:
   XFA_ELEMENT GetClassID() const { return (XFA_ELEMENT)m_eNodeClass; }
   uint32_t GetPacketID() const { return m_ePacket; }
   FX_BOOL HasFlag(uint32_t dwFlag) const;
-  void SetFlag(uint32_t dwFlag, FX_BOOL bOn = TRUE, FX_BOOL bNotify = TRUE);
+  void SetFlag(uint32_t dwFlag, bool bNotify);
+  void ClearFlag(uint32_t dwFlag);
+
   FX_BOOL IsAttributeInXML();
-  FX_BOOL IsFormContainer() {
+  bool IsFormContainer() const {
     return m_ePacket == XFA_XDPPACKET_Form && IsContainerNode();
   }
   void SetXMLMappingNode(CFDE_XMLNode* pXMLNode) { m_pXMLNode = pXMLNode; }
   CFDE_XMLNode* GetXMLMappingNode() const { return m_pXMLNode; }
   CFDE_XMLNode* CreateXMLMappingNode();
   FX_BOOL IsNeedSavingXMLNode();
   uint32_t GetNameHash() const { return m_dwNameHash; }
   bool IsUnnamed() const { return m_dwNameHash == 0; }
   CXFA_Node* GetModelNode();
   void UpdateNameHash();
   FX_BOOL HasAttribute(XFA_ATTRIBUTE eAttr, FX_BOOL bCanInherit = FALSE);
   FX_BOOL SetAttribute(XFA_ATTRIBUTE eAttr,
                        const CFX_WideStringC& wsValue,
-                       FX_BOOL bNotify = FALSE);
+                       bool bNotify = false);
   FX_BOOL GetAttribute(XFA_ATTRIBUTE eAttr,
                        CFX_WideString& wsValue,
                        FX_BOOL bUseDefault = TRUE);
   FX_BOOL SetAttribute(const CFX_WideStringC& wsAttr,
                        const CFX_WideStringC& wsValue,
-                       FX_BOOL bNotify = FALSE);
+                       bool bNotify = false);
   FX_BOOL GetAttribute(const CFX_WideStringC& wsAttr,
                        CFX_WideString& wsValue,
                        FX_BOOL bUseDefault = TRUE);
   FX_BOOL RemoveAttribute(const CFX_WideStringC& wsAttr);
   FX_BOOL SetContent(const CFX_WideString& wsContent,
                      const CFX_WideString& wsXMLValue,
-                     FX_BOOL bNotify = FALSE,
+                     bool bNotify = false,
                      FX_BOOL bScriptModify = FALSE,
                      FX_BOOL bSyncData = TRUE);
   FX_BOOL TryContent(CFX_WideString& wsContent,
                      FX_BOOL bScriptModify = FALSE,
                      FX_BOOL bProto = TRUE);
   CFX_WideString GetContent();
 
   FX_BOOL TryNamespace(CFX_WideString& wsNamespace);
 
   FX_BOOL SetBoolean(XFA_ATTRIBUTE eAttr,
                      FX_BOOL bValue,
-                     FX_BOOL bNotify = FALSE) {
+                     bool bNotify = false) {
     return SetValue(eAttr, XFA_ATTRIBUTETYPE_Boolean, (void*)(uintptr_t)bValue,
                     bNotify);
   }
   FX_BOOL TryBoolean(XFA_ATTRIBUTE eAttr,
                      FX_BOOL& bValue,
                      FX_BOOL bUseDefault = TRUE);
   FX_BOOL GetBoolean(XFA_ATTRIBUTE eAttr) {
     FX_BOOL bValue;
     return TryBoolean(eAttr, bValue, TRUE) ? bValue : FALSE;
   }
   FX_BOOL SetInteger(XFA_ATTRIBUTE eAttr,
                      int32_t iValue,
-                     FX_BOOL bNotify = FALSE) {
+                     bool bNotify = false) {
     return SetValue(eAttr, XFA_ATTRIBUTETYPE_Integer, (void*)(uintptr_t)iValue,
                     bNotify);
   }
   FX_BOOL TryInteger(XFA_ATTRIBUTE eAttr,
                      int32_t& iValue,
                      FX_BOOL bUseDefault = TRUE);
   int32_t GetInteger(XFA_ATTRIBUTE eAttr) {
     int32_t iValue;
     return TryInteger(eAttr, iValue, TRUE) ? iValue : 0;
   }
   FX_BOOL SetEnum(XFA_ATTRIBUTE eAttr,
                   XFA_ATTRIBUTEENUM eValue,
-                  FX_BOOL bNotify = FALSE) {
+                  bool bNotify = false) {
     return SetValue(eAttr, XFA_ATTRIBUTETYPE_Enum, (void*)(uintptr_t)eValue,
                     bNotify);
   }
   FX_BOOL TryEnum(XFA_ATTRIBUTE eAttr,
                   XFA_ATTRIBUTEENUM& eValue,
                   FX_BOOL bUseDefault = TRUE);
   XFA_ATTRIBUTEENUM GetEnum(XFA_ATTRIBUTE eAttr) {
     XFA_ATTRIBUTEENUM eValue;
     return TryEnum(eAttr, eValue, TRUE) ? eValue : XFA_ATTRIBUTEENUM_Unknown;
   }
   FX_BOOL SetCData(XFA_ATTRIBUTE eAttr,
                    const CFX_WideString& wsValue,
-                   FX_BOOL bNotify = FALSE,
+                   bool bNotify = false,
                    FX_BOOL bScriptModify = FALSE);
   FX_BOOL SetAttributeValue(const CFX_WideString& wsValue,
                             const CFX_WideString& wsXMLValue,
-                            FX_BOOL bNotify = FALSE,
+                            bool bNotify = false,
                             FX_BOOL bScriptModify = FALSE);
   FX_BOOL TryCData(XFA_ATTRIBUTE eAttr,
                    CFX_WideString& wsValue,
                    FX_BOOL bUseDefault = TRUE,
                    FX_BOOL bProto = TRUE);
   FX_BOOL TryCData(XFA_ATTRIBUTE eAttr,
                    CFX_WideStringC& wsValue,
                    FX_BOOL bUseDefault = TRUE,
                    FX_BOOL bProto = TRUE);
   CFX_WideStringC GetCData(XFA_ATTRIBUTE eAttr) {
     CFX_WideStringC wsValue;
     return TryCData(eAttr, wsValue) ? wsValue : CFX_WideStringC();
   }
   FX_BOOL SetMeasure(XFA_ATTRIBUTE eAttr,
                      CXFA_Measurement mValue,
-                     FX_BOOL bNotify = FALSE);
+                     bool bNotify = false);
   FX_BOOL TryMeasure(XFA_ATTRIBUTE eAttr,
                      CXFA_Measurement& mValue,
                      FX_BOOL bUseDefault = TRUE) const;
   CXFA_Measurement GetMeasure(XFA_ATTRIBUTE eAttr) const;
   FX_BOOL SetObject(XFA_ATTRIBUTE eAttr,
                     void* pData,
                     XFA_MAPDATABLOCKCALLBACKINFO* pCallbackInfo = NULL);
   FX_BOOL TryObject(XFA_ATTRIBUTE eAttr, void*& pData);
   void* GetObject(XFA_ATTRIBUTE eAttr) {
     void* pData;
     return TryObject(eAttr, pData) ? pData : NULL;
   }
   FX_BOOL SetUserData(void* pKey,
                       void* pData,
                       XFA_MAPDATABLOCKCALLBACKINFO* pCallbackInfo = NULL);
   FX_BOOL TryUserData(void* pKey, void*& pData, FX_BOOL bProtoAlso = FALSE);
   void* GetUserData(void* pKey, FX_BOOL bProtoAlso = FALSE) {
     void* pData;
     return TryUserData(pKey, pData, bProtoAlso) ? pData : NULL;
   }
   CXFA_Node* GetProperty(int32_t index,
                          XFA_ELEMENT eProperty,
                          FX_BOOL bCreateProperty = TRUE);
   int32_t CountChildren(XFA_ELEMENT eElement, FX_BOOL bOnlyChild = FALSE);
   CXFA_Node* GetChild(int32_t index,
                       XFA_ELEMENT eElement,
                       FX_BOOL bOnlyChild = FALSE);
   int32_t InsertChild(int32_t index, CXFA_Node* pNode);
   FX_BOOL InsertChild(CXFA_Node* pNode, CXFA_Node* pBeforeNode = NULL);
-  FX_BOOL RemoveChild(CXFA_Node* pNode, FX_BOOL bNotify = TRUE);
+  FX_BOOL RemoveChild(CXFA_Node* pNode, bool bNotify = true);
   CXFA_Node* Clone(FX_BOOL bRecursive);
   CXFA_Node* GetNodeItem(XFA_NODEITEM eItem) const;
   CXFA_Node* GetNodeItem(XFA_NODEITEM eItem, XFA_OBJECTTYPE eType) const;
   int32_t GetNodeList(CXFA_NodeArray& nodes,
                       uint32_t dwTypeFilter = XFA_NODEFILTER_Children |
                                               XFA_NODEFILTER_Properties,
                       XFA_ELEMENT eElementFilter = XFA_ELEMENT_UNKNOWN,
                       int32_t iLevel = 1);
   CXFA_Node* CreateSamePacketNode(XFA_ELEMENT eElement,
                                   uint32_t dwFlags = XFA_NODEFLAG_Initialized);
@@ skipping 91 matching lines @@
   void Script_Delta_Restore(CFXJSE_Arguments* pArguments);
   void Script_Delta_CurrentValue(FXJSE_HVALUE hValue,
                                  FX_BOOL bSetting,
                                  XFA_ATTRIBUTE eAttribute);
   void Script_Delta_SavedValue(FXJSE_HVALUE hValue,
                                FX_BOOL bSetting,
                                XFA_ATTRIBUTE eAttribute);
   void Script_Delta_Target(FXJSE_HVALUE hValue,
                            FX_BOOL bSetting,
                            XFA_ATTRIBUTE eAttribute);
-  void Script_Attribute_SendAttributeChangeMessage(void* eAttribute,
-                                                   void* eValue,
+  void Script_Attribute_SendAttributeChangeMessage(XFA_ATTRIBUTE eAttribute,
                                                    FX_BOOL bScriptModify);
   void Script_Attribute_Integer(FXJSE_HVALUE hValue,
                                 FX_BOOL bSetting,
                                 XFA_ATTRIBUTE eAttribute);
   void Script_Attribute_IntegerRead(FXJSE_HVALUE hValue,
                                     FX_BOOL bSetting,
                                     XFA_ATTRIBUTE eAttribute);
   void Script_Attribute_BOOL(FXJSE_HVALUE hValue,
                              FX_BOOL bSetting,
                              XFA_ATTRIBUTE eAttribute);
@@ skipping 195 matching lines @@
                                XFA_ATTRIBUTE eAttribute);
 
  protected:
   CXFA_Node(CXFA_Document* pDoc, uint16_t ePacket, XFA_ELEMENT eElement);
   ~CXFA_Node();
   friend class CXFA_Document;
   CXFA_Node* Deprecated_GetPrevSibling();
   FX_BOOL SetValue(XFA_ATTRIBUTE eAttr,
                    XFA_ATTRIBUTETYPE eType,
                    void* pValue,
-                   FX_BOOL bNotify);
+                   bool bNotify);
   FX_BOOL GetValue(XFA_ATTRIBUTE eAttr,
                    XFA_ATTRIBUTETYPE eType,
                    FX_BOOL bUseDefault,
                    void*& pValue);
-  void OnRemoved(CXFA_Node* pParent, CXFA_Node* pRemoved, FX_BOOL bNotify);
-  void OnChanging(XFA_ATTRIBUTE eAttr, void* pNewValue, FX_BOOL bNotify);
-  void OnChanged(XFA_ATTRIBUTE eAttr,
-                 void* pNewValue,
-                 FX_BOOL bNotify,
-                 FX_BOOL bScriptModify = FALSE);
+  void OnRemoved(bool bNotify);
+  void OnChanging(XFA_ATTRIBUTE eAttr, bool bNotify);
+  void OnChanged(XFA_ATTRIBUTE eAttr, bool bNotify, FX_BOOL bScriptModify);
   int32_t execSingleEventByName(const CFX_WideStringC& wsEventName,
                                 XFA_ELEMENT eElementType);
   FX_BOOL SetScriptContent(const CFX_WideString& wsContent,
                            const CFX_WideString& wsXMLValue,
-                           FX_BOOL bNotify = TRUE,
+                           bool bNotify = true,
                            FX_BOOL bScriptModify = FALSE,
                            FX_BOOL bSyncData = TRUE);
   CFX_WideString GetScriptContent(FX_BOOL bScriptModify = FALSE);
   XFA_MAPMODULEDATA* CreateMapModuleData();
   XFA_MAPMODULEDATA* GetMapModuleData() const;
   void SetMapModuleValue(void* pKey, void* pValue);
   FX_BOOL GetMapModuleValue(void* pKey, void*& pValue);
   void SetMapModuleString(void* pKey, const CFX_WideStringC& wsValue);
   FX_BOOL GetMapModuleString(void* pKey, CFX_WideStringC& wsValue);
   void SetMapModuleBuffer(void* pKey,
@@ skipping 174 matching lines @@
   return pObj ? pObj->AsNode() : nullptr;
 }
 inline const CXFA_OrdinaryObject* ToOrdinaryObject(const CXFA_Object* pObj) {
   return pObj ? pObj->AsOrdinaryObject() : nullptr;
 }
 inline const CXFA_NodeList* ToNodeList(const CXFA_Object* pObj) {
   return pObj ? pObj->AsNodeList() : nullptr;
 }
 
 #endif  // XFA_FXFA_PARSER_XFA_OBJECT_H_