Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1890553002: Revert of [heap] Better integrate handling of aborted compaction pages (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Better integrate handling of aborted compaction pages (patchset #7 id:130001 of https://codereview.chromium.org/1881423003/ ) Reason for revert: Breaks: https://uberchromegw.corp.google.com/i/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/20 RecordMigratedSlotVisitor is not safe to use on code pages. Original issue's description: > [heap] Better integrate handling of aborted compaction pages > > - Get rid of fixing up pointers on the main thread > - Get rid of sweeping on the main thread > > Instead: > - Record (and process afterwards) slots in parallel > - Add the pages to the concurrent sweeper as pointers have already been fixed > > BUG=chromium:581412 > LOG=N > TEST=cctest/test-compaction/* > > Committed: https://crrev.com/2e4f57774d4993f9f98332d3b2469280ee10beca > Cr-Commit-Position: refs/heads/master@{#35451} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Committed: https://crrev.com/6df04b296b87e1dad7eb4383167553e721e5fbd8 Cr-Commit-Position: refs/heads/master@{#35454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -40 lines) Patch
M src/heap/mark-compact.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 7 chunks +58 lines, -31 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/heap/test-compaction.cc View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Lippautz
Created Revert of [heap] Better integrate handling of aborted compaction pages
4 years, 8 months ago (2016-04-13 18:45:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890553002/1
4 years, 8 months ago (2016-04-13 18:45:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 18:45:18 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:46:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6df04b296b87e1dad7eb4383167553e721e5fbd8
Cr-Commit-Position: refs/heads/master@{#35454}

Powered by Google App Engine
This is Rietveld 408576698