Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1890533002:
Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. (Closed)
|
Created:
4 years, 8 months ago by bungeman-skia Modified:
4 years, 8 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionRespect FC_MATRIX and FC_EMBOLDEN as extra font parameters.
A font consists of a set of data and a set of parameters to that data.
For example a ttc font consists of the full font data parameterized by
the index. In addition to the index, FontConfig allows specifying a
matrix and embolden flag. In the future there may also be additional
parameters of this sort, for example which color palette to use.
This does not provide a way to serialize these parameters.
Adding this here provides a nice place to experiment with doing so.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1890533002
Committed: https://skia.googlesource.com/skia/+/d3b63d3244add67b1d087123f36a418f7fd7ec0f
Patch Set 1 #Patch Set 2 : Fix handedness. #Messages
Total messages: 20 (11 generated)
Description was changed from ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. ========== to ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890533002/1
Description was changed from ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890533002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. This does not provide a way to serialize these parameters. Adding this here provides a nice place to experiment with doing so. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. This does not provide a way to serialize these parameters. Adding this here provides a nice place to experiment with doing so. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. This does not provide a way to serialize these parameters. Adding this here provides a nice place to experiment with doing so. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
bungeman@google.com changed reviewers: + mtklein@google.com, reed@google.com
We need to be more flexible in how we serialize typefaces. We need to respect these FontConfig parameters anyway, so use this as a test bed example. This is a nice place to put this since, as far as I know, none of our large users are heavily using this particular path.
lgtm ... this certainly begs the question of how to "de-dup" typefaces during serialization, since N typefaces can share the same 99% base file blob.
On 2016/04/13 19:44:06, reed1 wrote: > lgtm ... this certainly begs the question of how to "de-dup" typefaces during > serialization, since N typefaces can share the same 99% base file blob. Yeah, all parameters cause some issues here: indexes, gx axes, matrix, embolden, color palette, an open ended dictionary of svg valriables...
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890533002/20001
Message was sent while issue was closed.
Description was changed from ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. This does not provide a way to serialize these parameters. Adding this here provides a nice place to experiment with doing so. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Respect FC_MATRIX and FC_EMBOLDEN as extra font parameters. A font consists of a set of data and a set of parameters to that data. For example a ttc font consists of the full font data parameterized by the index. In addition to the index, FontConfig allows specifying a matrix and embolden flag. In the future there may also be additional parameters of this sort, for example which color palette to use. This does not provide a way to serialize these parameters. Adding this here provides a nice place to experiment with doing so. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/d3b63d3244add67b1d087123f36a418f7fd7ec0f ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/d3b63d3244add67b1d087123f36a418f7fd7ec0f |
