Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: third_party/WebKit/public/web/WebConsoleMessage.h

Issue 1890513004: Remove dependency on the DevTools agent for console logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebConsoleMessage.h
diff --git a/third_party/WebKit/public/web/WebConsoleMessage.h b/third_party/WebKit/public/web/WebConsoleMessage.h
index d0a109c348648438725fa143008e69ce0fb816cf..148a7d13824daff765181b3b9ccbbdef08060432 100644
--- a/third_party/WebKit/public/web/WebConsoleMessage.h
+++ b/third_party/WebKit/public/web/WebConsoleMessage.h
@@ -36,6 +36,20 @@
namespace blink {
struct WebConsoleMessage {
+ enum class Source {
+ XML,
+ JS,
+ Network,
+ ConsoleAPI,
+ Storage,
+ AppCache,
+ Rendering,
+ Security,
+ Other,
+ Deprecation,
+ Last = Deprecation
+ };
+
enum Level {
LevelDebug = 4,
LevelLog = 1,
@@ -49,11 +63,13 @@ struct WebConsoleMessage {
Level level;
WebString text;
WebString url;
+ Source source;
unsigned lineNumber;
unsigned columnNumber;
WebConsoleMessage()
: level(LevelLog)
+ , source(Source::Other)
, lineNumber(0)
, columnNumber(0)
{
@@ -61,6 +77,7 @@ struct WebConsoleMessage {
WebConsoleMessage(Level level, const WebString& text)
: level(level)
, text(text)
+ , source(Source::Other)
, lineNumber(0)
, columnNumber(0)
{

Powered by Google App Engine
This is Rietveld 408576698