content/browser/frame_host/render_frame_host_impl.cc - Issue 1890513004: Remove dependency on the DevTools agent for console logs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1890513004: Remove dependency on the DevTools agent for console logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.h ('K') | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/common/frame_messages.h » ('j') | content/common/frame_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 4e4c97ae48d538e7b08119d120de39de21e31b3a..b20643741bb0f2ac3cff453bd17584ba508ee90f 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -356,6 +356,12 @@ void RenderFrameHostImpl::AddMessageToConsole(ConsoleMessageLevel level,

Send(new FrameMsg_AddMessageToConsole(routing_id_, level, message));

}

+void RenderFrameHostImpl::AddSecurityMessageToConsole(

pfeldman 2016/04/21 21:48:30 We already have one above.

+ ConsoleMessageLevel level,

+ const std::string& message) {

+ Send(new FrameMsg_AddSecurityMessageToConsole(routing_id_, level, message));

void RenderFrameHostImpl::ExecuteJavaScript(

const base::string16& javascript) {

CHECK(CanExecuteJavaScript());