Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp |
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp |
index 765da87a8896da493e0798b6a11908ce10a3dafc..73e0eeb259f5870916d35f874825ff0bec949e6d 100644 |
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp |
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp |
@@ -769,7 +769,44 @@ void WebLocalFrameImpl::addMessageToConsole(const WebConsoleMessage& message) |
return; |
} |
- frame()->document()->addConsoleMessage(ConsoleMessage::create(OtherMessageSource, webCoreMessageLevel, message.text, message.url, message.lineNumber, message.columnNumber)); |
+ MessageSource webCoreMessageSource; |
+ switch (message.source) { |
+ case WebConsoleMessage::SourceXML: |
dcheng
2016/04/14 17:29:11
FWIW, the usual idiom is to make the core and web
carlosk
2016/04/15 09:42:43
Static casting was I wanted to do initially but ag
|
+ webCoreMessageSource = XMLMessageSource; |
+ break; |
+ case WebConsoleMessage::SourceJS: |
+ webCoreMessageSource = JSMessageSource; |
+ break; |
+ case WebConsoleMessage::SourceNetwork: |
+ webCoreMessageSource = NetworkMessageSource; |
+ break; |
+ case WebConsoleMessage::SourceConsoleAPI: |
+ webCoreMessageSource = ConsoleAPIMessageSource; |
+ break; |
+ case WebConsoleMessage::SourceStorage: |
+ webCoreMessageSource = StorageMessageSource; |
+ break; |
+ case WebConsoleMessage::SourceAppCache: |
+ webCoreMessageSource = AppCacheMessageSource; |
+ break; |
+ case WebConsoleMessage::SourceRendering: |
+ webCoreMessageSource = RenderingMessageSource; |
+ break; |
+ case WebConsoleMessage::SourceSecurity: |
+ webCoreMessageSource = SecurityMessageSource; |
+ break; |
+ case WebConsoleMessage::SourceOther: |
+ webCoreMessageSource = OtherMessageSource; |
+ break; |
+ case WebConsoleMessage::SourceDeprecation: |
+ webCoreMessageSource = DeprecationMessageSource; |
+ break; |
+ default: |
dcheng
2016/04/14 17:29:11
That being said, if you keep the switch (though it
carlosk
2016/04/15 09:42:43
My rule of thumb is to create a central, shared me
|
+ NOTREACHED(); |
+ return; |
+ } |
+ |
+ frame()->document()->addConsoleMessage(ConsoleMessage::create(webCoreMessageSource, webCoreMessageLevel, message.text, message.url, message.lineNumber, message.columnNumber)); |
} |
void WebLocalFrameImpl::collectGarbage() |