Remove dependency on the DevTools agent for console logs.

third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 732 matching lines @@
 void WebLocalFrameImpl::setIsolatedWorldHumanReadableName(int worldID, const WebString& humanReadableName)
 {
     DCHECK(frame());
     DOMWrapperWorld::setIsolatedWorldHumanReadableName(worldID, humanReadableName);
 }
 
 void WebLocalFrameImpl::addMessageToConsole(const WebConsoleMessage& message)
 {
     DCHECK(frame());
 
-    MessageLevel webCoreMessageLevel;
+    MessageSource webCoreMessageSource = OtherMessageSource;

[pfeldman, 2016/04/21 21:48:30]

You have static assert, you should be fine casting.

[carlosk, 2016/04/22 14:33:55]

This code was fully removed.

+    switch (message.source) {
+    case WebConsoleMessage::Source::XML:
+        webCoreMessageSource = XMLMessageSource;
+        break;
+    case WebConsoleMessage::Source::JS:
+        webCoreMessageSource = JSMessageSource;
+        break;
+    case WebConsoleMessage::Source::Network:
+        webCoreMessageSource = NetworkMessageSource;
+        break;
+    case WebConsoleMessage::Source::ConsoleAPI:
+        webCoreMessageSource = ConsoleAPIMessageSource;
+        break;
+    case WebConsoleMessage::Source::Storage:
+        webCoreMessageSource = StorageMessageSource;
+        break;
+    case WebConsoleMessage::Source::AppCache:
+        webCoreMessageSource = AppCacheMessageSource;
+        break;
+    case WebConsoleMessage::Source::Rendering:
+        webCoreMessageSource = RenderingMessageSource;
+        break;
+    case WebConsoleMessage::Source::Security:
+        webCoreMessageSource = SecurityMessageSource;
+        break;
+    case WebConsoleMessage::Source::Other:
+        webCoreMessageSource = OtherMessageSource;
+        break;
+    case WebConsoleMessage::Source::Deprecation:
+        webCoreMessageSource = DeprecationMessageSource;
+        break;
+    }
+
+    MessageLevel webCoreMessageLevel = LogMessageLevel;
     switch (message.level) {
     case WebConsoleMessage::LevelDebug:
         webCoreMessageLevel = DebugMessageLevel;
         break;
     case WebConsoleMessage::LevelLog:
         webCoreMessageLevel = LogMessageLevel;
         break;
     case WebConsoleMessage::LevelWarning:
         webCoreMessageLevel = WarningMessageLevel;
         break;
     case WebConsoleMessage::LevelError:
         webCoreMessageLevel = ErrorMessageLevel;
         break;
-    default:
-        NOTREACHED();
-        return;
+    // Unsupported values.
+    case WebConsoleMessage::LevelInfo:
+    case WebConsoleMessage::LevelRevokedError:
+        break;
     }
 
-    frame()->document()->addConsoleMessage(ConsoleMessage::create(OtherMessageSource, webCoreMessageLevel, message.text, message.url, message.lineNumber, message.columnNumber));
+    frame()->document()->addConsoleMessage(ConsoleMessage::create(webCoreMessageSource, webCoreMessageLevel, message.text, message.url, message.lineNumber, message.columnNumber));
 }
 
 void WebLocalFrameImpl::collectGarbage()
 {
     if (!frame())
         return;
     if (!frame()->settings()->scriptEnabled())
         return;
     V8GCController::collectGarbage(v8::Isolate::GetCurrent());
 }
@@ skipping 1346 matching lines @@
         return WebSandboxFlags::None;
     return static_cast<WebSandboxFlags>(frame()->loader().effectiveSandboxFlags());
 }
 
 void WebLocalFrameImpl::forceSandboxFlags(WebSandboxFlags flags)
 {
     frame()->loader().forceSandboxFlags(static_cast<SandboxFlags>(flags));
 }
 
 } // namespace blink