Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1890513004: Remove dependency on the DevTools agent for console logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 SiteInstanceImpl* GetSiteInstance() override; 120 SiteInstanceImpl* GetSiteInstance() override;
121 RenderProcessHost* GetProcess() override; 121 RenderProcessHost* GetProcess() override;
122 RenderWidgetHostView* GetView() override; 122 RenderWidgetHostView* GetView() override;
123 RenderFrameHostImpl* GetParent() override; 123 RenderFrameHostImpl* GetParent() override;
124 int GetFrameTreeNodeId() override; 124 int GetFrameTreeNodeId() override;
125 const std::string& GetFrameName() override; 125 const std::string& GetFrameName() override;
126 bool IsCrossProcessSubframe() override; 126 bool IsCrossProcessSubframe() override;
127 const GURL& GetLastCommittedURL() override; 127 const GURL& GetLastCommittedURL() override;
128 url::Origin GetLastCommittedOrigin() override; 128 url::Origin GetLastCommittedOrigin() override;
129 gfx::NativeView GetNativeView() override; 129 gfx::NativeView GetNativeView() override;
130 void AddMessageToConsole(ConsoleMessageLevel level, 130 void AddMessageToConsole(ConsoleMessageLevel level,
pfeldman 2016/04/21 21:48:30 We already have one.
131 const std::string& message) override; 131 const std::string& message) override;
132 void ExecuteJavaScript(const base::string16& javascript) override; 132 void ExecuteJavaScript(const base::string16& javascript) override;
133 void ExecuteJavaScript(const base::string16& javascript, 133 void ExecuteJavaScript(const base::string16& javascript,
134 const JavaScriptResultCallback& callback) override; 134 const JavaScriptResultCallback& callback) override;
135 void ExecuteJavaScriptInIsolatedWorld( 135 void ExecuteJavaScriptInIsolatedWorld(
136 const base::string16& javascript, 136 const base::string16& javascript,
137 const JavaScriptResultCallback& callback, 137 const JavaScriptResultCallback& callback,
138 int world_id) override; 138 int world_id) override;
139 void ExecuteJavaScriptForTests(const base::string16& javascript) override; 139 void ExecuteJavaScriptForTests(const base::string16& javascript) override;
140 void ExecuteJavaScriptForTests( 140 void ExecuteJavaScriptForTests(
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 // separately so that the ScopedPageLoadDeferrers of any current dialogs are 547 // separately so that the ScopedPageLoadDeferrers of any current dialogs are
548 // no longer on the stack when we attempt to swap it out. 548 // no longer on the stack when we attempt to swap it out.
549 void SuppressFurtherDialogs(); 549 void SuppressFurtherDialogs();
550 550
551 // PlzNavigate: returns the LoFi state of the last successful navigation that 551 // PlzNavigate: returns the LoFi state of the last successful navigation that
552 // made a network request. 552 // made a network request.
553 LoFiState last_navigation_lofi_state() const { 553 LoFiState last_navigation_lofi_state() const {
554 return last_navigation_lofi_state_; 554 return last_navigation_lofi_state_;
555 } 555 }
556 556
557 void AddSecurityMessageToConsole(ConsoleMessageLevel level,
558 const std::string& message);
559
557 protected: 560 protected:
558 friend class RenderFrameHostFactory; 561 friend class RenderFrameHostFactory;
559 562
560 // |flags| is a combination of CreateRenderFrameFlags. 563 // |flags| is a combination of CreateRenderFrameFlags.
561 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost 564 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost
562 // should be the abstraction needed here, but we need RenderViewHost to pass 565 // should be the abstraction needed here, but we need RenderViewHost to pass
563 // into WebContentsObserver::FrameDetached for now. 566 // into WebContentsObserver::FrameDetached for now.
564 RenderFrameHostImpl(SiteInstance* site_instance, 567 RenderFrameHostImpl(SiteInstance* site_instance,
565 RenderViewHostImpl* render_view_host, 568 RenderViewHostImpl* render_view_host,
566 RenderFrameHostDelegate* delegate, 569 RenderFrameHostDelegate* delegate,
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
969 972
970 // NOTE: This must be the last member. 973 // NOTE: This must be the last member.
971 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 974 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
972 975
973 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 976 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
974 }; 977 };
975 978
976 } // namespace content 979 } // namespace content
977 980
978 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 981 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698