Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1890503002: Add Animometer "Focus" test to tough_filters_cases, and update. (Closed)

Created:
4 years, 8 months ago by Stephen White
Modified:
4 years, 8 months ago
Reviewers:
eakuefner
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Animometer "Focus" test to tough_filters_cases, and update. Also update IE Pirates demo URL to use archive.org, since the site has been removed. BUG= Committed: https://crrev.com/45d9e5fc911867073607fcdf095a8be2fc1d022d Cr-Commit-Position: refs/heads/master@{#387462}

Patch Set 1 #

Patch Set 2 : disable line-too-long warnings #

Patch Set 3 : re-run wpr record; add missing SHA1 #

Total comments: 4

Patch Set 4 : Style changes per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M tools/perf/page_sets/data/tough_filters_cases.json View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
A tools/perf/page_sets/data/tough_filters_cases_002.wpr.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/tough_filters_cases.py View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
Stephen White
eakuefner@: PTAL. Thanks!
4 years, 8 months ago (2016-04-13 16:25:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890503002/1
4 years, 8 months ago (2016-04-13 16:25:17 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/168089)
4 years, 8 months ago (2016-04-13 16:36:09 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890503002/20001
4 years, 8 months ago (2016-04-13 17:08:40 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890503002/40001
4 years, 8 months ago (2016-04-13 17:23:52 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 18:28:51 UTC) #13
Stephen White
eakuefner: ping?
4 years, 8 months ago (2016-04-14 18:08:16 UTC) #14
eakuefner
lgtm with nits https://codereview.chromium.org/1890503002/diff/40001/tools/perf/page_sets/tough_filters_cases.py File tools/perf/page_sets/tough_filters_cases.py (right): https://codereview.chromium.org/1890503002/diff/40001/tools/perf/page_sets/tough_filters_cases.py#newcode36 tools/perf/page_sets/tough_filters_cases.py:36: 'http://rawgit.com/WebKit/webkit/master/PerformanceTests/Animometer/developer.html?test-interval=20&display=minimal&controller=fixed&frame-rate=50&kalman-process-error=1&kalman-measurement-error=4&time-measurement=performance&suite-name=Animometer&test-name=Focus&complexity=100', please put the disable at ...
4 years, 8 months ago (2016-04-14 18:40:07 UTC) #15
Stephen White
https://codereview.chromium.org/1890503002/diff/40001/tools/perf/page_sets/tough_filters_cases.py File tools/perf/page_sets/tough_filters_cases.py (right): https://codereview.chromium.org/1890503002/diff/40001/tools/perf/page_sets/tough_filters_cases.py#newcode36 tools/perf/page_sets/tough_filters_cases.py:36: 'http://rawgit.com/WebKit/webkit/master/PerformanceTests/Animometer/developer.html?test-interval=20&display=minimal&controller=fixed&frame-rate=50&kalman-process-error=1&kalman-measurement-error=4&time-measurement=performance&suite-name=Animometer&test-name=Focus&complexity=100', On 2016/04/14 18:40:07, eakuefner wrote: > please put ...
4 years, 8 months ago (2016-04-14 20:54:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890503002/60001
4 years, 8 months ago (2016-04-14 20:55:12 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-14 22:40:31 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 22:42:51 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/45d9e5fc911867073607fcdf095a8be2fc1d022d
Cr-Commit-Position: refs/heads/master@{#387462}

Powered by Google App Engine
This is Rietveld 408576698