Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + fixed issue with layout test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 5250e551593f0ea486b13bce87abff37147f8188..24a23eb9dea15d6035a6cc9568e802983c4e90e0 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -688,13 +688,6 @@ WebPerformance WebLocalFrameImpl::performance() const
return WebPerformance(DOMWindowPerformance::performance(*(frame()->domWindow())));
}
-bool WebLocalFrameImpl::dispatchBeforeUnloadEvent()
-{
- if (!frame())
- return true;
- return frame()->loader().shouldClose();
-}
-
void WebLocalFrameImpl::dispatchUnloadEvent()
{
if (!frame())
@@ -1830,6 +1823,14 @@ void WebLocalFrameImpl::sendPings(const WebURL& destinationURL)
toHTMLAnchorElement(anchor)->sendPings(destinationURL);
}
+bool WebLocalFrameImpl::dispatchBeforeUnloadEvent(bool isReload)
+{
+ if (!frame())
+ return true;
+
+ return frame()->loader().shouldClose(isReload);
+}
+
WebURLRequest WebLocalFrameImpl::requestFromHistoryItem(const WebHistoryItem& item, WebCachePolicy cachePolicy) const
{
HistoryItem* historyItem = item;
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/Source/web/WebRemoteFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698