content/renderer/render_frame_impl.h - Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + fixed issue with layout test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 3ddbf72d8c089821d021833c62ee879a7294abe3..ae5dae610bcbd9de9ba20f004a593cc36d2a9c78 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -738,7 +738,7 @@ class CONTENT_EXPORT RenderFrameImpl

void OnNavigate(const CommonNavigationParams& common_params,

const StartNavigationParams& start_params,

const RequestNavigationParams& request_params);

- void OnBeforeUnload();

+ void OnBeforeUnload(bool is_reload);

void OnSwapOut(int proxy_routing_id,

bool is_loading,

const FrameReplicationState& replicated_frame_state);

« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »