Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + fixed issue with layout test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 420a2c2795d7512d3ac241213dc4854290d45737..d8024794a0128b506b7bc2ddcf449dc4f65732aa 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -398,9 +398,11 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,
// Runs the beforeunload handler for this frame. |for_navigation| indicates
// whether this call is for the current frame during a cross-process
- // navigation. False means we're closing the entire tab.
+ // navigation. False means we're closing the entire tab. |is_reload|
+ // indicates whether the navigation is a reload of the page or not. If
+ // |for_navigation| is false, |is_reload| should be false as well.
// PlzNavigate: this call happens on all browser-initiated navigations.
- void DispatchBeforeUnload(bool for_navigation);
+ void DispatchBeforeUnload(bool for_navigation, bool is_reload);
// Simulate beforeunload ack on behalf of renderer if it's unrenresponsive.
void SimulateBeforeUnloadAck();
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698