Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1577)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
index f3becd7d61894453c9634a5c2dc4c3a94a8b8792..68f6fb72cbb83b15ea1b21872630b6f71e8533aa 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
@@ -96,7 +96,6 @@ public:
WebView* view() const override;
WebDocument document() const override;
WebPerformance performance() const override;
- bool dispatchBeforeUnloadEvent() override;
void dispatchUnloadEvent() override;
void executeScript(const WebScriptSource&) override;
void executeScriptInIsolatedWorld(
@@ -208,6 +207,7 @@ public:
WebLocalFrame* traversePreviousLocal(bool wrap) const override;
WebLocalFrame* traverseNextLocal(bool wrap) const override;
void sendPings(const WebURL& destinationURL) override;
+ bool dispatchBeforeUnloadEvent(bool) override;
WebURLRequest requestFromHistoryItem(const WebHistoryItem&, WebCachePolicy) const override;
WebURLRequest requestForReload(WebFrameLoadType, const WebURL&) const override;
void load(const WebURLRequest&, WebFrameLoadType, const WebHistoryItem&,

Powered by Google App Engine
This is Rietveld 408576698