third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation - Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations

Unified Diff: third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/test_runner_for_specific_view.cc ('K') | « testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

diff --git a/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation b/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

index fc8679ec354f8a5b981cb1e73ee7120c43592f3a..1a84386fcfe4f89d12e933aa98dbf0968f203d86 100644

--- a/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

+++ b/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

@@ -1,20 +1,6 @@

# These tests currently fail when run with --enable-browser-side-navigation

# See https://crbug.com/576261

-# https://crbug.com/608371: PlzNavigate: properly execute the BeforeUnload event

- editing/pasteboard/file-drag-to-editable.html [ Crash Failure ]

- fast/events/before-unload-forbidden-navigation.html [ Crash ]

- fast/events/before-unload-return-value-from-listener.html [ Crash Failure ]

- fast/events/drop-handler-should-not-stop-navigate.html [ Crash Failure ]

- fast/loader/recursive-before-unload-crash.html [ Crash Failure ]

- http/tests/history/back-during-beforeunload.html [ Crash ]

- virtual/pointerevent/fast/events/before-unload-forbidden-navigation.html [ Crash ]

- virtual/pointerevent/fast/events/before-unload-return-value-from-listener.html [ Crash Failure ]

- virtual/pointerevent/fast/events/drop-handler-should-not-stop-navigate.html [ Crash Failure ]

- virtual/trustedeventsdefaultaction/fast/events/before-unload-forbidden-navigation.html [ Crash ]

- virtual/trustedeventsdefaultaction/fast/events/before-unload-return-value-from-listener.html [ Crash Failure ]

- virtual/trustedeventsdefaultaction/fast/events/drop-handler-should-not-stop-navigate.html [ Crash Failure ]

# https://crbug.com/608372: PlzNavigate: support POST navigations

fast/forms/state-restore-skip-stateless.html [ Crash ]

fast/forms/submit-to-url-fragment.html [ Failure ]

@@ -37,6 +23,10 @@

# Failing due to error page supression in layout tests

fast/xmlhttprequest/null-document-xmlhttprequest-open.html [ Crash Timeout ]

+# Failing due to extra error due to bad timing.

+ fast/events/before-unload-in-subframe.html [ Crash ]

+ virtual/trustedeventsdefaultaction/fast/events/before-unload-in-subframe.html [ Crash ]

# Failing due to empty data url

editing/execCommand/apply-style-command-crash.html [ Crash ]

editing/style/apply-style-crash.html [ Crash ]