content/common/frame_messages.h - Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/test_runner_for_specific_view.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 72baac5eb7fd41f06127e1024fef8101a6d4e34d..a337b848522646ef49a46069f7d3ce496309d562 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -644,7 +644,7 @@ IPC_MESSAGE_ROUTED3(FrameMsg_Navigate,

// Instructs the renderer to invoke the frame's beforeunload event handler.

// Expects the result to be returned via FrameHostMsg_BeforeUnload_ACK.

-IPC_MESSAGE_ROUTED0(FrameMsg_BeforeUnload)

+IPC_MESSAGE_ROUTED1(FrameMsg_BeforeUnload, bool /* is_reload */)

// Instructs the frame to swap out for a cross-site transition, including

// running the unload event handler and creating a RenderFrameProxy with the