content/browser/frame_host/render_frame_host_manager.h - Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/test_runner_for_specific_view.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.h

diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h

index ee6e16ef0aaa9b05feb52d50f2d0a060a5f348c1..1dd6559b390972800ad7dbb1bd8b54fb7abd30f6 100644

--- a/content/browser/frame_host/render_frame_host_manager.h

+++ b/content/browser/frame_host/render_frame_host_manager.h

@@ -268,7 +268,8 @@ class CONTENT_EXPORT RenderFrameHostManager

// different URL than the last committed entry, without modifying it).

RenderFrameHostImpl* Navigate(const GURL& dest_url,

const FrameNavigationEntry& frame_entry,

- const NavigationEntryImpl& entry);

+ const NavigationEntryImpl& entry,

+ bool is_reload);

// Instructs the various live views to stop. Called when the user directed the

// page to stop loading.

@@ -720,7 +721,8 @@ class CONTENT_EXPORT RenderFrameHostManager

bool dest_is_restore,

bool dest_is_view_source_mode,

const GlobalRequestID& transferred_request_id,

- int bindings);

+ int bindings,

+ bool is_reload);

// Updates the pending WebUI of the current RenderFrameHost for a same-site

// navigation.