third_party/WebKit/Source/web/WebLocalFrameImpl.h - Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed dcheng's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.cc ('K') | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | third_party/WebKit/public/web/WebLocalFrame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

index 7e531182a4165f42128fc4f058a15f7b652a1417..b17516fb2cc708f088cfe04919ba83400954e861 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

@@ -96,7 +96,6 @@ public:

WebView* view() const override;

WebDocument document() const override;

WebPerformance performance() const override;

- bool dispatchBeforeUnloadEvent() override;

void dispatchUnloadEvent() override;

void executeScript(const WebScriptSource&) override;

void executeScriptInIsolatedWorld(

@@ -208,6 +207,7 @@ public:

WebLocalFrame* traversePreviousLocal(bool wrap) const override;

WebLocalFrame* traverseNextLocal(bool wrap) const override;

void sendPings(const WebURL& destinationURL) override;

+ WebLocalFrame::BeforeUnloadReturnValue dispatchBeforeUnloadEvent(bool) override;

WebURLRequest requestFromHistoryItem(const WebHistoryItem&, WebCachePolicy) const override;

WebURLRequest requestForReload(WebFrameLoadType, const WebURL&) const override;

void load(const WebURLRequest&, WebFrameLoadType, const WebHistoryItem&,