third_party/WebKit/public/web/WebFrame.h - Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now only calling BeforeUnload from the embedder Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('K') | « third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | third_party/WebKit/public/web/WebLocalFrame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/WebFrame.h

diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h

index 5b3d907d5ffb46b048a7d4a041613c2bdcd56260..8fced50ca0891192f830a31bb00f20cd799bb5b9 100644

--- a/third_party/WebKit/public/web/WebFrame.h

+++ b/third_party/WebKit/public/web/WebFrame.h

@@ -254,10 +254,6 @@ public:

// Closing -------------------------------------------------------------

- // Runs beforeunload handlers for this frame, returning false if a

- // handler suppressed unloading.

- virtual bool dispatchBeforeUnloadEvent() = 0;

dcheng 2016/05/03 06:51:59 Thanks for moving this

// Runs unload handlers for this frame.

virtual void dispatchUnloadEvent() = 0;