Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 880 matching lines...) Expand 10 before | Expand all | Expand 10 after
891 891
892 // Creates a factory object used for creating audio and video renderers. 892 // Creates a factory object used for creating audio and video renderers.
893 std::unique_ptr<MediaStreamRendererFactory> CreateRendererFactory(); 893 std::unique_ptr<MediaStreamRendererFactory> CreateRendererFactory();
894 894
895 // Does preparation for the navigation to |url|. 895 // Does preparation for the navigation to |url|.
896 void PrepareRenderViewForNavigation( 896 void PrepareRenderViewForNavigation(
897 const GURL& url, 897 const GURL& url,
898 const RequestNavigationParams& request_params); 898 const RequestNavigationParams& request_params);
899 899
900 // PlzNavigate 900 // PlzNavigate
901 // Sends a FrameHostMsg_BeginNavigation to the browser based on the contents 901 // Called when a navigation should be sent to the browser via a
902 // of the WebURLRequest. 902 // FrameHostMsg_BeginNavigation IPC (based on the contents of |request|).
903 // Returns true if the navigation was actually sent to the browser, false
904 // otherwise.
903 // |should_replace_current_entry| indicates that the current history entry 905 // |should_replace_current_entry| indicates that the current history entry
904 // will be replaced when the navigation commits. |is_client_redirect| 906 // will be replaced when the navigation commits. |is_client_redirect|
905 // indicates that the navigation originated as a client redirect. 907 // indicates that the navigation originated as a client redirect.
906 // Note: those two concepts are separate. For example, a location.assign is a 908 // Note: those two concepts are separate. For example, a location.assign is a
907 // client redirect but it only replaces the current entry if called before 909 // client redirect but it only replaces the current entry if called before
908 // load stop. location.replace on the other hand is a client redirect and 910 // load stop. location.replace on the other hand is a client redirect and
909 // always replaces the current entry. 911 // always replaces the current entry.
910 void BeginNavigation(blink::WebURLRequest* request, 912 bool BeginNavigation(blink::WebURLRequest* request,
911 bool should_replace_current_entry, 913 bool should_replace_current_entry,
912 bool is_client_redirect); 914 bool is_client_redirect);
913 915
914 // Loads a data url. 916 // Loads a data url.
915 void LoadDataURL(const CommonNavigationParams& params, 917 void LoadDataURL(const CommonNavigationParams& params,
916 const RequestNavigationParams& request_params, 918 const RequestNavigationParams& request_params,
917 blink::WebLocalFrame* frame, 919 blink::WebLocalFrame* frame,
918 blink::WebFrameLoadType load_type, 920 blink::WebFrameLoadType load_type,
919 blink::WebHistoryItem item_for_history_navigation, 921 blink::WebHistoryItem item_for_history_navigation,
920 blink::WebHistoryLoadType history_load_type, 922 blink::WebHistoryLoadType history_load_type,
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
1227 FrameBlameContext* blame_context_; // Not owned. 1229 FrameBlameContext* blame_context_; // Not owned.
1228 1230
1229 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1231 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1230 1232
1231 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1233 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1232 }; 1234 };
1233 1235
1234 } // namespace content 1236 } // namespace content
1235 1237
1236 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1238 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698