Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 1890453006: Revert of Flock master startup. (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Flock master startup. (patchset #3 id:40001 of https://codereview.chromium.org/1883813003/ ) Reason for revert: This breaks the ability to restart internal masters (crbug.com/603584) Original issue's description: > Flock master startup. > > Since the flock fd is inherited by the master as it starts up, this protects it even before it can drop twisted.pid. This change has been tested to work on linux. > > BUG=588118 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299916 TBR=pgervais@chromium.org,stip@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588118 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -42 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M masters/master-common-rules.mk View 2 chunks +9 lines, -14 lines 0 comments Download
D masters/start_master.sh View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dnj
Created Revert of Flock master startup.
4 years, 8 months ago (2016-04-14 15:24:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890453006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890453006/1
4 years, 8 months ago (2016-04-14 15:25:02 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 15:25:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299930

Powered by Google App Engine
This is Rietveld 408576698