[Refactor] Replace static casts to WebContentsImpl with member function.

[Refactor] Replace static casts to WebContentsImpl with member function.

Replace static casts to WebContentsImpl with member function.

BUG=602646
Committed: https://crrev.com/fd1b5cfa2cdbafeb27ce0dc1981f77136df0b72f
Cr-Commit-Position: refs/heads/master@{#388095}

[EhsanK, 2016-04-14 05:01:22]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org

[EhsanK, 2016-04-14 05:01:23]

Sorry for the loads of reviews on my side. This one is not really urgent.

I took this out of cl 1652483002 to submit later. This CL is purely refactoring
by replacing all static casts of shell()->web_contents() into impl with
web_contents(). PTAL.

[Charlie Reis, 2016-04-15 05:25:56]

No problem.  Thanks for the cleanup!  LGTM with nits.

https://codereview.chromium.org/1890453002/diff/20001/content/browser/site_pe...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/1890453002/diff/20001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:4432: WebContentsImpl* contents
= web_contents();
nit: This doesn't seem necessary.  Just call web_contents() below, since it's
not expensive.

https://codereview.chromium.org/1890453002/diff/20001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:4620: WebContentsImpl* contents
= web_contents();
Same.

https://codereview.chromium.org/1890453002/diff/20001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:5419: WebContentsImpl* contents
= web_contents();
Same.

https://codereview.chromium.org/1890453002/diff/20001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:6030: WebContentsImpl* contents
= web_contents();
Same.

[Charlie Reis, 2016-04-15 05:26:15]

Description was changed from

==========
[Refactor] Replace static casts to WebContentsImpl with member function.

Replace static casts to WebContentsImpl with member function.

BUG=602646
==========

to

==========
[Refactor] Replace static casts to WebContentsImpl with member function.

Replace static casts to WebContentsImpl with member function.

BUG=602646
==========

[EhsanK, 2016-04-15 11:29:09]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2016-04-15 11:29:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890453002/20001

[commit-bot: I haz the power, 2016-04-15 11:31:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 11:31:55]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Charlie Reis, 2016-04-15 21:10:05]

By the way, don't land this now.  It depends on changes to
site_per_process_browsertest.h that we're reverting in
https://codereview.chromium.org/1889313002/.

I would recommend pulling those changes into this CL and landing it
independently, after the reverts are all done.

[EhsanK, 2016-04-18 15:37:01]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 15:37:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890453002/60001

[commit-bot: I haz the power, 2016-04-18 16:19:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 16:19:13]

Dry run: This issue passed the CQ dry run.

[EhsanK, 2016-04-19 00:24:11]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2016-04-19 00:24:11]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1890453002/#ps60001
(title: "Merged after Rebase of 1652483002")

[EhsanK, 2016-04-19 00:24:16]

The CQ bit was unchecked by ekaramad@chromium.org

[EhsanK, 2016-04-19 00:29:44]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2016-04-19 00:30:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890453002/60001

[commit-bot: I haz the power, 2016-04-19 00:35:20]

Description was changed from

==========
[Refactor] Replace static casts to WebContentsImpl with member function.

Replace static casts to WebContentsImpl with member function.

BUG=602646
==========

to

==========
[Refactor] Replace static casts to WebContentsImpl with member function.

Replace static casts to WebContentsImpl with member function.

BUG=602646
==========

[commit-bot: I haz the power, 2016-04-19 00:35:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-19 00:36:23]

Description was changed from

==========
[Refactor] Replace static casts to WebContentsImpl with member function.

Replace static casts to WebContentsImpl with member function.

BUG=602646
==========

to

==========
[Refactor] Replace static casts to WebContentsImpl with member function.

Replace static casts to WebContentsImpl with member function.

BUG=602646

Committed: https://crrev.com/fd1b5cfa2cdbafeb27ce0dc1981f77136df0b72f
Cr-Commit-Position: refs/heads/master@{#388095}
==========

[commit-bot: I haz the power, 2016-04-19 00:36:25]

Patchset 4 (id:??) landed as
https://crrev.com/fd1b5cfa2cdbafeb27ce0dc1981f77136df0b72f
Cr-Commit-Position: refs/heads/master@{#388095}