Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1890443002: Remove IFX_Barcode. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IFX_Barcode. This CL replaces IFX_Barcode with the concrete class. BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/eb9cf677ca1bfd9431e43804b5524a1cf9bd9a8f

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -123 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M xfa.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.h View 1 2 chunks +16 lines, -13 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fxmath_barcodeimp.h View 1 chunk +38 lines, -36 lines 0 comments Download
M xfa/fwl/basewidget/fxmath_barcodeimp.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
D xfa/fwl/basewidget/ifx_barcode.h View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-13 15:04:12 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1890443002/diff/1/xfa/fwl/basewidget/fwl_barcodeimp.h File xfa/fwl/basewidget/fwl_barcodeimp.h (right): https://codereview.chromium.org/1890443002/diff/1/xfa/fwl/basewidget/fwl_barcodeimp.h#newcode26 xfa/fwl/basewidget/fwl_barcodeimp.h:26: virtual ~CFWL_BarcodeImp(); nit: are these virtuals or overrides? ...
4 years, 8 months ago (2016-04-13 16:52:18 UTC) #3
dsinclair
https://codereview.chromium.org/1890443002/diff/1/xfa/fwl/basewidget/fwl_barcodeimp.h File xfa/fwl/basewidget/fwl_barcodeimp.h (right): https://codereview.chromium.org/1890443002/diff/1/xfa/fwl/basewidget/fwl_barcodeimp.h#newcode26 xfa/fwl/basewidget/fwl_barcodeimp.h:26: virtual ~CFWL_BarcodeImp(); On 2016/04/13 16:52:18, Tom Sepez wrote: > ...
4 years, 8 months ago (2016-04-13 16:59:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890443002/20001
4 years, 8 months ago (2016-04-13 16:59:23 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:14:31 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/eb9cf677ca1bfd9431e43804b5524a1cf9bd...

Powered by Google App Engine
This is Rietveld 408576698