Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1839)

Unified Diff: android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java

Issue 1890343003: aw: Use functor callback for lifetime management (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix UAF for realz Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwGLFunctor.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
diff --git a/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java b/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
index b17033d75a41f99e0a8daf4f7da067a54d23ae02..13e0fe20d24609e7ca453b938851c7f9d68833db 100644
--- a/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
+++ b/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
@@ -417,13 +417,14 @@ public class AwTestContainerView extends FrameLayout {
private class NativeGLDelegate implements AwContents.NativeGLDelegate {
@Override
- public boolean setDrawGLFunctionDetachedCallback(View view, Runnable callback) {
+ public boolean supportsDrawGLFunctorReleasedCallback() {
return false;
}
@Override
- public boolean requestDrawGL(Canvas canvas, boolean waitForCompletion,
- View containerview) {
+ public boolean requestDrawGL(Canvas canvas, boolean waitForCompletion, View containerview,
+ Runnable releasedRunnable) {
+ assert releasedRunnable == null;
if (!isBackedByHardwareView()) return false;
mHardwareView.requestRender(canvas, waitForCompletion);
return true;
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwGLFunctor.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698