ios/web/shell/view_controller.h - Issue 1890333002: Web shell test to go back and forward.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/shell/view_controller.h

Issue 1890333002: Web shell test to go back and forward. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_WEB_SHELL_VIEW_CONTROLLER_H_	5 #ifndef IOS_WEB_SHELL_VIEW_CONTROLLER_H_

6 #define IOS_WEB_SHELL_VIEW_CONTROLLER_H_	6 #define IOS_WEB_SHELL_VIEW_CONTROLLER_H_

7	7

8 #import <UIKit/UIKit.h>	8 #import <UIKit/UIKit.h>

9	9

10 #include "ios/web/public/web_state/ui/crw_web_delegate.h"	10 #include "ios/web/public/web_state/ui/crw_web_delegate.h"

(...skipping 15 matching lines...) Expand all Loading...
26	26

27 @property(nonatomic, retain) IBOutlet UIView* containerView;	27 @property(nonatomic, retain) IBOutlet UIView* containerView;

28 @property(nonatomic, retain) IBOutlet UIToolbar* toolbarView;	28 @property(nonatomic, retain) IBOutlet UIToolbar* toolbarView;

29	29

30 // Initializes a new ViewController from \|MainView.xib\| using the given	30 // Initializes a new ViewController from \|MainView.xib\| using the given

31 // \|browserState\|.	31 // \|browserState\|.

32 - (instancetype)initWithBrowserState:(web::BrowserState*)browserState;	32 - (instancetype)initWithBrowserState:(web::BrowserState*)browserState;

33	33

34 @end	34 @end

35	35

	36 @interface ViewController (ExposedForTesting)
	Eugene But (OOO till 7-30) 2016/04/16 00:38:41 I don't see any issues with making WebState a publ I don't see any issues with making WebState a public property. WebController should not be exposed, more over it will be completely removed from WebShell baxley 2016/04/21 16:09:18 Done. Show quoted text On 2016/04/16 00:38:41, Eugene But wrote: > I don't see any issues with making WebState a public property. WebController > should not be exposed, more over it will be completely removed from WebShell Done.
	37 - (CRWWebController*)webController;

	38 @end

	39

36 #endif // IOS_WEB_SHELL_VIEW_CONTROLLER_H_	40 #endif // IOS_WEB_SHELL_VIEW_CONTROLLER_H_

OLD	NEW

« ios/web/shell/test/web_shell_navigation_egtest.mm ('K') | « ios/web/shell/test/web_shell_navigation_egtest.mm ('k') | ios/web/shell/view_controller.mm » ('j') | no next file with comments »