ios/web/shell/test/utils/eg_util.mm - Issue 1890333002: Web shell test to go back and forward.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/shell/test/utils/eg_util.mm

Issue 1890333002: Web shell test to go back and forward. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ios/web/shell/test/utils/eg_util.h"

	6

	7 #import "ios/web/shell/view_controller.h"

	8

	9 namespace earl_grey_util {

	10

	11 CRWWebController* GetCurrentWebController() {

	12 ViewController* vc = (ViewController*)[
	Eugene But (OOO till 7-30) 2016/04/16 00:38:40 From Style Guide: Readers should be able to infer From Style Guide: Readers should be able to infer the variable type from the name, but do not use Hungarian notation for syntactic attributes, such as the static type of a variable (int or pointer). Give as descriptive a name as possible, within reason. Please use more descriptive name than vc. baxley 2016/04/21 16:09:17 Done. Show quoted text On 2016/04/16 00:38:40, Eugene But wrote: > From Style Guide: > > Readers should be able to infer the variable type from the name, but do not use > Hungarian notation for syntactic attributes, such as the static type of a > variable (int or pointer). Give as descriptive a name as possible, within > reason. > > Please use more descriptive name than vc. Done.
	13 [[[UIApplication sharedApplication] delegate] window] rootViewController];

	14 DCHECK(vc);

	15 CRWWebController* wc = [vc webController];
	Eugene But (OOO till 7-30) 2016/04/16 00:38:40 NIT: Drop this variable NIT: Drop this variable baxley 2016/04/21 16:09:17 Acknowledged. Show quoted text On 2016/04/16 00:38:40, Eugene But wrote: > NIT: Drop this variable Acknowledged.
	16 return wc;

	17 }

	18

	19 } // namespace earl_grey_util

OLD	NEW

« ios/web/shell/test/utils/eg_util.h ('K') | « ios/web/shell/test/utils/eg_util.h ('k') | ios/web/shell/test/utils/web_view_egutil.h » ('j') | ios/web/shell/test/utils/web_view_egutil.mm » ('J')