ios/web/shell/test/utils/eg_util.h - Issue 1890333002: Web shell test to go back and forward.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/shell/test/utils/eg_util.h

Issue 1890333002: Web shell test to go back and forward. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_SHELL_TEST_UTILS_EG_UTIL_H_

	6 #define IOS_WEB_SHELL_TEST_UTILS_EG_UTIL_H_

	7

	8 #import "ios/web/shell/view_controller.h"

	9

	10 namespace earl_grey_util {
	Eugene But (OOO till 7-30) 2016/04/16 00:38:40 This is very generic name, which does not provide This is very generic name, which does not provide any restrictions of what should be put here. What other API do you plan to have in this file? Maybe name it web_state_test_util? baxley 2016/04/21 16:09:17 moved to navigation_egutil Show quoted text On 2016/04/16 00:38:40, Eugene But wrote: > This is very generic name, which does not provide any restrictions of what > should be put here. What other API do you plan to have in this file? Maybe name > it web_state_test_util? moved to navigation_egutil
	11

	12 // Get current web controller.

	13 CRWWebController* GetCurrentWebController();
	Eugene But (OOO till 7-30) 2016/04/16 00:38:40 WebController is private part of web. This should WebController is private part of web. This should return WebState instead. baxley 2016/04/21 16:09:17 Done. Show quoted text On 2016/04/16 00:38:40, Eugene But wrote: > WebController is private part of web. This should return WebState instead. Done.
	14

	15 } // namespace earl_grey_util

	16

	17 #endif // IOS_WEB_SHELL_TEST_UTILS_EG_UTIL_H_

OLD	NEW