Subzero, Wasm: Link and run torture tests; bug fixes.

src/IceCfgNode.cpp

 //===- subzero/src/IceCfgNode.cpp - Basic block (node) implementation -----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 10 matching lines @@
 #include "IceInst.h"
 #include "IceInstVarIter.h"
 #include "IceLiveness.h"
 #include "IceOperand.h"
 #include "IceTargetLowering.h"
 
 namespace Ice {
 
 // Adds an instruction to either the Phi list or the regular instruction list.
 // Validates that all Phis are added before all regular instructions.
-void CfgNode::appendInst(Inst *Instr, bool AllowPhisAnywhere) {
+void CfgNode::appendInst(Inst *Instr) {
   ++InstCountEstimate;
 
   if (BuildDefs::wasm()) {
     if (llvm::isa<InstSwitch>(Instr) || llvm::isa<InstBr>(Instr)) {
       for (auto *N : Instr->getTerminatorEdges()) {
         N->addInEdge(this);
         addOutEdge(N);
       }
     }
   }
 
   if (auto *Phi = llvm::dyn_cast<InstPhi>(Instr)) {
-    if (!AllowPhisAnywhere && !Insts.empty()) {
+    if (!Insts.empty()) {
       Func->setError("Phi instruction added to the middle of a block");
       return;
     }
     Phis.push_back(Phi);
   } else {
     Insts.push_back(Instr);
   }
 }
 
 namespace {
@@ skipping 22 matching lines @@
 // have to be built up incrementally. After the CFG has been constructed, the
 // computePredecessors() pass finalizes it by creating the InEdges list.
 void CfgNode::computePredecessors() {
   for (CfgNode *Succ : OutEdges)
     Succ->InEdges.push_back(this);
 }
 
 void CfgNode::computeSuccessors() {
   OutEdges.clear();
   InEdges.clear();
+  assert(!Insts.empty());
   OutEdges = Insts.rbegin()->getTerminatorEdges();
 }
 
 // Ensure each Phi instruction in the node is consistent with respect to control
 // flow.  For each predecessor, there must be a phi argument with that label.
 // If a phi argument's label doesn't appear in the predecessor list (which can
 // happen as a result of e.g. unreachable node elimination), its value is
 // modified to be zero, to maintain consistency in liveness analysis.  This
 // allows us to remove some dead control flow without a major rework of the phi
 // instructions.  We don't check that phi arguments with the same label have the
@@ skipping 1368 matching lines @@
   auto *Instr = InstIntrinsicCall::create(
       Func, 5, Func->makeVariable(IceType_i64), RMWI64Name, Info->Info);
   Instr->addArg(AtomicRMWOp);
   Instr->addArg(Counter);
   Instr->addArg(One);
   Instr->addArg(OrderAcquireRelease);
   Insts.push_front(Instr);
 }
 
 } // end of namespace Ice